Tidy up <select>s in tabbed options.

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
   /////////////////////////////////////////////////////////////////////////////
   // PrefCheckbox class:
   // TODO(jhawkins): Refactor all this copy-pasted code!
@@ skipping 390 matching lines @@
             if (!found)
               self.selectedIndex = 0;
 
             if (self.onchange != undefined)
               self.onchange(event);
           });
 
       // Listen to user events.
       this.addEventListener('change',
           function(e) {
-            if (!self.dataType)
-              console.error('unknown data type for <select> pref');
+            if (!self.dataType) {
+              console.error('undefined data type for <select> pref');
+              return;
+            }
 
             switch(self.dataType) {
               case 'number':
                 Preferences.setIntegerPref(self.pref,
                     self.options[self.selectedIndex].value, self.metric);
                 break;
+              case 'real':
+                Preferences.setRealPref(self.pref,
+                    self.options[self.selectedIndex].value, self.metric);
+                break;
               case 'boolean':
                 var option = self.options[self.selectedIndex];
                 var value = (option.value == 'true') ? true : false;
                 Preferences.setBooleanPref(self.pref, value, self.metric);
                 break;
               case 'string':
-              case undefined:  // Assume the pref is a string.
                 Preferences.setStringPref(self.pref,
                     self.options[self.selectedIndex].value, self.metric);
                 break;
+              default:
+                console.error('unknown data type for <select> pref: ' +
+                              self.dataType);
             }
           });
     },
+
+    /**
+     * Getter for preference data type attribute.
+     */
+    get dataType() {
+      return this.getAttribute('dataType');
+    },
+    /**
+     * Setter for preference data type attribute.
+     */

[stuartmorgan, 2011/01/12 22:59:41]

The code I've seen doesn't have separate docs for getters and setters, just one
doc explaining what the property means, and with a @type line.

[Evan Stade, 2011/01/12 23:19:20]

i copied this style from within this same file.

+    set dataType(name) {
+      this.setAttribute('dataType', name);
+    }
   };
 
   /**
    * The preference name.
    * @type {string}
    */
   cr.defineProperty(PrefSelect, 'pref', cr.PropertyKind.ATTR);
 
   /**
    * The user metric string.
@@ skipping 63 matching lines @@
     PrefCheckbox: PrefCheckbox,
     PrefNumber: PrefNumber,
     PrefNumeric: PrefNumeric,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField
   };
 
 });