Makes the instant url managed by group policy.

Makes the instant url managed by group policy.

BUG=64870
64922
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71172

[jeanluc1, 2011-01-10 19:26:41]

Those changes are good but not sufficient.  You also need to change the .json
file that is used to create the templates and the documentation.  Check
chrome/app/policy/policy_templates.{json,grd)

[jeanluc1, 2011-01-10 19:40:22]

On 2011/01/10 19:26:41, jeanluc1 wrote:
> Those changes are good but not sufficient.  You also need to change the .json
> file that is used to create the templates and the documentation.  Check
> chrome/app/policy/policy_templates.{json,grd)

Also check whether these need changes:

chrome\browser\policy\config_dir_policy_provider_unittest.cc
chrome\browser\policy\configuration_policy_provider_mac_unittest.cc
chrome\browser\policy\configuration_policy_provider_win_unittest.cc
chrome\browser\search_engines\template_url_model.cc
chrome\browser\search_engines\template_url_model_unittest.cc
chrome\common\policy_constants.cc
chrome\common\policy_constants.h
chrome\common\pref_names.cc
chrome\common\pref_names.h

[jeanluc1, 2011-01-10 21:18:46]

On 2011/01/10 19:40:22, jeanluc1 wrote:
> On 2011/01/10 19:26:41, jeanluc1 wrote:
> > Those changes are good but not sufficient.  You also need to change the
.json
> > file that is used to create the templates and the documentation.  Check
> > chrome/app/policy/policy_templates.{json,grd)
> 
> Also check whether these need changes:
> 
> chrome\browser\policy\config_dir_policy_provider_unittest.cc
> chrome\browser\policy\configuration_policy_provider_mac_unittest.cc
> chrome\browser\policy\configuration_policy_provider_win_unittest.cc
> chrome\browser\search_engines\template_url_model.cc
> chrome\browser\search_engines\template_url_model_unittest.cc
> chrome\common\policy_constants.cc
> chrome\common\policy_constants.h
> chrome\common\pref_names.cc
> chrome\common\pref_names.h

There's also src\chrome\browser\policy\configuration_policy_store_interface.h

[sky, 2011-01-10 21:48:12]

Ok, I think I got them all.

I didn't need to touch template_url_* as that was already done.

Thanks,

  -Scott

On Mon, Jan 10, 2011 at 1:18 PM,  <jeanluc@chromium.org> wrote:
> On 2011/01/10 19:40:22, jeanluc1 wrote:
>>
>> On 2011/01/10 19:26:41, jeanluc1 wrote:
>> > Those changes are good but not sufficient.  You also need to change the
>
> .json
>>
>> > file that is used to create the templates and the documentation.  Check
>> > chrome/app/policy/policy_templates.{json,grd)
>
>> Also check whether these need changes:
>
>> chrome\browser\policy\config_dir_policy_provider_unittest.cc
>> chrome\browser\policy\configuration_policy_provider_mac_unittest.cc
>> chrome\browser\policy\configuration_policy_provider_win_unittest.cc
>> chrome\browser\search_engines\template_url_model.cc
>> chrome\browser\search_engines\template_url_model_unittest.cc
>> chrome\common\policy_constants.cc
>> chrome\common\policy_constants.h
>> chrome\common\pref_names.cc
>> chrome\common\pref_names.h
>
> There's also
> src\chrome\browser\policy\configuration_policy_store_interface.h
>
>
> http://codereview.chromium.org/6174002/
>

[jeanluc1, 2011-01-10 23:35:02]

Have you figured out why the buildbots are failing?

On 2011/01/10 21:48:12, sky wrote:
> Ok, I think I got them all.
> 
> I didn't need to touch template_url_* as that was already done.
> 
> Thanks,
> 
>   -Scott
> 
> On Mon, Jan 10, 2011 at 1:18 PM,  <mailto:jeanluc@chromium.org> wrote:
> > On 2011/01/10 19:40:22, jeanluc1 wrote:
> >>
> >> On 2011/01/10 19:26:41, jeanluc1 wrote:
> >> > Those changes are good but not sufficient. &nbsp;You also need to change
the
> >
> > .json
> >>
> >> > file that is used to create the templates and the documentation.
&nbsp;Check
> >> > chrome/app/policy/policy_templates.{json,grd)
> >
> >> Also check whether these need changes:
> >
> >> chrome\browser\policy\config_dir_policy_provider_unittest.cc
> >> chrome\browser\policy\configuration_policy_provider_mac_unittest.cc
> >> chrome\browser\policy\configuration_policy_provider_win_unittest.cc
> >> chrome\browser\search_engines\template_url_model.cc
> >> chrome\browser\search_engines\template_url_model_unittest.cc
> >> chrome\common\policy_constants.cc
> >> chrome\common\policy_constants.h
> >> chrome\common\pref_names.cc
> >> chrome\common\pref_names.h
> >
> > There's also
> > src\chrome\browser\policy\configuration_policy_store_interface.h
> >
> >
> > http://codereview.chromium.org/6174002/
> >

[sky, 2011-01-11 17:00:27]

Ok, I think I got it all now.

  -Scott

[jeanluc1, 2011-01-11 21:47:37]

LGTM