Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/renderer/renderer_webidbtransaction_impl.cc

Issue 6173008: Clean up some old TODOs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/renderer_webidbobjectstore_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/renderer_webidbtransaction_impl.h" 5 #include "chrome/renderer/renderer_webidbtransaction_impl.h"
6 6
7 #include "chrome/common/indexed_db_messages.h" 7 #include "chrome/common/indexed_db_messages.h"
8 #include "chrome/renderer/indexed_db_dispatcher.h" 8 #include "chrome/renderer/indexed_db_dispatcher.h"
9 #include "chrome/renderer/render_thread.h" 9 #include "chrome/renderer/render_thread.h"
10 #include "chrome/renderer/renderer_webidbobjectstore_impl.h" 10 #include "chrome/renderer/renderer_webidbobjectstore_impl.h"
11 #include "third_party/WebKit/WebKit/chromium/public/WebIDBObjectStore.h" 11 #include "third_party/WebKit/WebKit/chromium/public/WebIDBObjectStore.h"
12 #include "third_party/WebKit/WebKit/chromium/public/WebIDBTransactionCallbacks.h " 12 #include "third_party/WebKit/WebKit/chromium/public/WebIDBTransactionCallbacks.h "
13 #include "third_party/WebKit/WebKit/chromium/public/WebString.h" 13 #include "third_party/WebKit/WebKit/chromium/public/WebString.h"
14 14
15 using WebKit::WebIDBObjectStore; 15 using WebKit::WebIDBObjectStore;
16 using WebKit::WebIDBTransactionCallbacks; 16 using WebKit::WebIDBTransactionCallbacks;
17 using WebKit::WebString; 17 using WebKit::WebString;
18 18
19 RendererWebIDBTransactionImpl::RendererWebIDBTransactionImpl( 19 RendererWebIDBTransactionImpl::RendererWebIDBTransactionImpl(
20 int32 idb_transaction_id) 20 int32 idb_transaction_id)
21 : idb_transaction_id_(idb_transaction_id) { 21 : idb_transaction_id_(idb_transaction_id) {
22 } 22 }
23 23
24 RendererWebIDBTransactionImpl::~RendererWebIDBTransactionImpl() { 24 RendererWebIDBTransactionImpl::~RendererWebIDBTransactionImpl() {
25 // It's not possible for there to be pending callbacks that address this
26 // object since inside WebKit, they hold a reference to the object wich owns
27 // this object. But, if that ever changed, then we'd need to invalidate
28 // any such pointers.
25 RenderThread::current()->Send(new IndexedDBHostMsg_TransactionDestroyed( 29 RenderThread::current()->Send(new IndexedDBHostMsg_TransactionDestroyed(
26 idb_transaction_id_)); 30 idb_transaction_id_));
27 } 31 }
28 32
29 int RendererWebIDBTransactionImpl::mode() const 33 int RendererWebIDBTransactionImpl::mode() const
30 { 34 {
31 int mode; 35 int mode;
32 RenderThread::current()->Send(new IndexedDBHostMsg_TransactionMode( 36 RenderThread::current()->Send(new IndexedDBHostMsg_TransactionMode(
33 idb_transaction_id_, &mode)); 37 idb_transaction_id_, &mode));
34 return mode; 38 return mode;
(...skipping 26 matching lines...) Expand all
61 } 65 }
62 66
63 void RendererWebIDBTransactionImpl::setCallbacks( 67 void RendererWebIDBTransactionImpl::setCallbacks(
64 WebIDBTransactionCallbacks* callbacks) 68 WebIDBTransactionCallbacks* callbacks)
65 { 69 {
66 IndexedDBDispatcher* dispatcher = 70 IndexedDBDispatcher* dispatcher =
67 RenderThread::current()->indexed_db_dispatcher(); 71 RenderThread::current()->indexed_db_dispatcher();
68 dispatcher->RegisterWebIDBTransactionCallbacks(callbacks, 72 dispatcher->RegisterWebIDBTransactionCallbacks(callbacks,
69 idb_transaction_id_); 73 idb_transaction_id_);
70 } 74 }
OLDNEW
« no previous file with comments | « chrome/renderer/renderer_webidbobjectstore_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698