Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/renderer/renderer_webidbobjectstore_impl.cc

Issue 6173008: Clean up some old TODOs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/renderer_webidbobjectstore_impl.h" 5 #include "chrome/renderer/renderer_webidbobjectstore_impl.h"
6 6
7 #include "chrome/common/indexed_db_messages.h" 7 #include "chrome/common/indexed_db_messages.h"
8 #include "chrome/common/serialized_script_value.h" 8 #include "chrome/common/serialized_script_value.h"
9 #include "chrome/renderer/indexed_db_dispatcher.h" 9 #include "chrome/renderer/indexed_db_dispatcher.h"
10 #include "chrome/renderer/render_thread.h" 10 #include "chrome/renderer/render_thread.h"
(...skipping 16 matching lines...) Expand all
27 using WebKit::WebIDBTransaction; 27 using WebKit::WebIDBTransaction;
28 using WebKit::WebSerializedScriptValue; 28 using WebKit::WebSerializedScriptValue;
29 using WebKit::WebString; 29 using WebKit::WebString;
30 30
31 RendererWebIDBObjectStoreImpl::RendererWebIDBObjectStoreImpl( 31 RendererWebIDBObjectStoreImpl::RendererWebIDBObjectStoreImpl(
32 int32 idb_object_store_id) 32 int32 idb_object_store_id)
33 : idb_object_store_id_(idb_object_store_id) { 33 : idb_object_store_id_(idb_object_store_id) {
34 } 34 }
35 35
36 RendererWebIDBObjectStoreImpl::~RendererWebIDBObjectStoreImpl() { 36 RendererWebIDBObjectStoreImpl::~RendererWebIDBObjectStoreImpl() {
37 // It's not possible for there to be pending callbacks that address this
38 // object since inside WebKit, they hold a reference to the object wich owns
39 // this object. But, if that ever changed, then we'd need to invalidate
40 // any such pointers.
37 RenderThread::current()->Send( 41 RenderThread::current()->Send(
38 new IndexedDBHostMsg_ObjectStoreDestroyed(idb_object_store_id_)); 42 new IndexedDBHostMsg_ObjectStoreDestroyed(idb_object_store_id_));
39 } 43 }
40 44
41 WebString RendererWebIDBObjectStoreImpl::name() const { 45 WebString RendererWebIDBObjectStoreImpl::name() const {
42 string16 result; 46 string16 result;
43 RenderThread::current()->Send( 47 RenderThread::current()->Send(
44 new IndexedDBHostMsg_ObjectStoreName(idb_object_store_id_, &result)); 48 new IndexedDBHostMsg_ObjectStoreName(idb_object_store_id_, &result));
45 return result; 49 return result;
46 } 50 }
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 const WebIDBKeyRange& idb_key_range, 152 const WebIDBKeyRange& idb_key_range,
149 unsigned short direction, WebIDBCallbacks* callbacks, 153 unsigned short direction, WebIDBCallbacks* callbacks,
150 const WebIDBTransaction& transaction, 154 const WebIDBTransaction& transaction,
151 WebExceptionCode& ec) { 155 WebExceptionCode& ec) {
152 IndexedDBDispatcher* dispatcher = 156 IndexedDBDispatcher* dispatcher =
153 RenderThread::current()->indexed_db_dispatcher(); 157 RenderThread::current()->indexed_db_dispatcher();
154 dispatcher->RequestIDBObjectStoreOpenCursor( 158 dispatcher->RequestIDBObjectStoreOpenCursor(
155 idb_key_range, direction, callbacks, idb_object_store_id_, 159 idb_key_range, direction, callbacks, idb_object_store_id_,
156 transaction, &ec); 160 transaction, &ec);
157 } 161 }
OLDNEW
« no previous file with comments | « chrome/renderer/renderer_webidbindex_impl.cc ('k') | chrome/renderer/renderer_webidbtransaction_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698