Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: media/filters/omx_video_decoder.h

Issue 6171009: Remove MessageLoop methods from Filter interface (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Apply CR suggestions & fix style issues. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/omx_video_decoder.h
diff --git a/media/filters/omx_video_decoder.h b/media/filters/omx_video_decoder.h
index 7eb850488286be8f9793ff7d358f18462aca4dce..ade638fabb2e6289bc022d85bd21de5973d512d0 100644
--- a/media/filters/omx_video_decoder.h
+++ b/media/filters/omx_video_decoder.h
@@ -23,7 +23,8 @@ class VideoFrame;
class OmxVideoDecoder : public VideoDecoder,
public VideoDecodeEngine::EventHandler {
public:
- explicit OmxVideoDecoder(VideoDecodeContext* decode_context);
+ OmxVideoDecoder(MessageLoop* message_loop,
+ VideoDecodeContext* decode_context);
virtual ~OmxVideoDecoder();
// Filter implementations.
@@ -35,6 +36,7 @@ class OmxVideoDecoder : public VideoDecoder,
virtual bool ProvidesBuffer();
virtual const MediaFormat& media_format();
+ MessageLoop* message_loop();
scherkus (not reviewing) 2011/01/13 23:52:50 nit: add blank line after this
acolwell GONE FROM CHROMIUM 2011/01/14 01:14:12 Removed method since it is no longer needed. On 20
private:
// VideoDecodeEngine::EventHandler interface.
virtual void OnInitializeComplete(const VideoCodecInfo& info);
@@ -50,6 +52,8 @@ class OmxVideoDecoder : public VideoDecoder,
// scoped_refptr.
void DemuxCompleteTask(Buffer* buffer);
+ MessageLoop* message_loop_;
+
// Pointer to the demuxer stream that will feed us compressed buffers.
scoped_refptr<DemuxerStream> demuxer_stream_;
scoped_ptr<VideoDecodeEngine> decode_engine_;

Powered by Google App Engine
This is Rietveld 408576698