Remove MessageLoop methods from Filter interface

media/filters/ffmpeg_demuxer.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Demuxer interface using FFmpeg's libavformat.  At this time
 // will support demuxing any audio/video format thrown at it.  The streams
 // output mime types audio/x-ffmpeg and video/x-ffmpeg and include an integer
 // key FFmpegCodecID which contains the CodecID enumeration value.  The CodecIDs
 // can be used to create and initialize the corresponding FFmpeg decoder.
 //
@@ skipping 103 matching lines @@
 
   // Used to translate bitstream formats.
   scoped_ptr<BitstreamConverter> bitstream_converter_;
 
   DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxerStream);
 };
 
 class FFmpegDemuxer : public Demuxer,
                       public FFmpegURLProtocol {
  public:
-  FFmpegDemuxer();
+  explicit FFmpegDemuxer(MessageLoop* message_loop);
   virtual ~FFmpegDemuxer();
 
   // Posts a task to perform additional demuxing.
   virtual void PostDemuxTask();
 
   // Filter implementation.
   virtual void Stop(FilterCallback* callback);
   virtual void Seek(base::TimeDelta time, FilterCallback* callback);
   virtual void OnAudioRendererDisabled();
 
   // Demuxer implementation.
   virtual void Initialize(DataSource* data_source, FilterCallback* callback);
   virtual size_t GetNumberOfStreams();
   virtual scoped_refptr<DemuxerStream> GetStream(int stream_id);
 
   // FFmpegProtocol implementation.
   virtual int Read(int size, uint8* data);
   virtual bool GetPosition(int64* position_out);
   virtual bool SetPosition(int64 position);
   virtual bool GetSize(int64* size_out);
   virtual bool IsStreaming();
 
+  MessageLoop* message_loop();

[scherkus (not reviewing), 2011/01/13 23:52:50]

who's calling this method today?

[acolwell GONE FROM CHROMIUM, 2011/01/14 01:14:12]

FFmpegDemuxerStream. Some rework could be done to eliminate the need, but that
should be in a separate CL.
On 2011/01/13 23:52:50, scherkus wrote:

+
  private:
   // Only allow a factory to create this class.
   friend class MockFFmpegDemuxer;
   FRIEND_TEST_ALL_PREFIXES(FFmpegDemuxerTest, ProtocolRead);
 
   // Carries out initialization on the demuxer thread.
   void InitializeTask(DataSource* data_source, FilterCallback* callback);
 
   // Carries out a seek on the demuxer thread.
   void SeekTask(base::TimeDelta time, FilterCallback* callback);
@@ skipping 23 matching lines @@
   // read has completed, this method will be called from DataSource with
   // number of bytes read or kDataSource in case of error.
   void OnReadCompleted(size_t size);
 
   // Wait for asynchronous read to complete and return number of bytes read.
   virtual size_t WaitForRead();
 
   // Signal that read has completed, and |size| bytes have been read.
   virtual void SignalReadCompleted(size_t size);
 
+  MessageLoop* message_loop_;
+
   // FFmpeg context handle.
   AVFormatContext* format_context_;
 
   // Two vector of streams:
   //   - |streams_| is indexed for the Demuxer interface GetStream(), which only
   //     contains supported streams and no NULL entries.
   //   - |packet_streams_| is indexed to mirror AVFormatContext when dealing
   //     with AVPackets returned from av_read_frame() and contain NULL entries
   //     representing unsupported streams where we throw away the data.
   //
@@ skipping 20 matching lines @@
 
   size_t last_read_bytes_;
   int64 read_position_;
 
   DISALLOW_COPY_AND_ASSIGN(FFmpegDemuxer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_FFMPEG_DEMUXER_H_