Remove MessageLoop methods from Filter interface

media/base/message_loop_factory_impl.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/message_loop_factory_impl.h"
+
+namespace media {
+
+MessageLoopFactoryImpl::MessageLoopFactoryImpl() {}
+
+MessageLoopFactoryImpl::~MessageLoopFactoryImpl() {
+  AutoLock auto_lock(lock_);
+
+  for (ThreadMap::iterator iter = thread_map_.begin();
+       iter != thread_map_.end();
+       ++iter) {
+    base::Thread* thread = (*iter).second;
+
+    if (thread) {
+      thread->Stop();
+      delete thread;
+    }
+  }
+  thread_map_.clear();
+}
+
+// MessageLoopFactory methods.
+MessageLoop* MessageLoopFactoryImpl::GetMessageLoop(const std::string& name) {
+  if (name.empty()) {
+    return NULL;
+  }
+
+  MessageLoop* message_loop = NULL;
+  AutoLock auto_lock(lock_);
+
+  base::Thread* thread = thread_map_[std::string(name)];

[scherkus (not reviewing), 2011/01/13 23:52:50]

no need for std::string ctor here

also do we want to use thread_map_.find() instead?  otherwise we'll create an
entry

[acolwell GONE FROM CHROMIUM, 2011/01/14 01:14:12]

Done. Changed code to use find.

On 2011/01/13 23:52:50, scherkus wrote:

+
+  if (!thread) {
+    thread = new base::Thread(name.c_str());
+
+    if (thread->Start()) {
+      thread_map_[name] = thread;
+      message_loop = thread->message_loop();

[scherkus (not reviewing), 2011/01/13 23:52:50]

wondering if we can clean up these nested ifs by just doing:

if (thread)
  return thread->message_loop();

thread = new Thread();
if (thread->Start()) {
  // blah..
  return thread->message_loop();
}

LOG(ERROR) << "OMG"
return NULL;

[acolwell GONE FROM CHROMIUM, 2011/01/14 01:14:12]

Done.

+    } else {
+      delete thread;

[scherkus (not reviewing), 2011/01/13 23:52:50]

maybe LOG(ERROR)?

[acolwell GONE FROM CHROMIUM, 2011/01/14 01:14:12]

Done.

+    }
+  } else {
+    message_loop = thread->message_loop();
+  }
+
+  return message_loop;
+}
+
+}  // namespace media