chrome/browser/diagnostics/recon_diagnostics.cc - Issue 6171004: Fix minor CHECKED_RETURN Coverity complaint in code I added to the --diagnost...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/diagnostics/recon_diagnostics.cc

Issue 6171004: Fix minor CHECKED_RETURN Coverity complaint in code I added to the --diagnost... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/diagnostics/recon_diagnostics.cc

===================================================================

--- chrome/browser/diagnostics/recon_diagnostics.cc (revision 70876)

+++ chrome/browser/diagnostics/recon_diagnostics.cc (working copy)

@@ -97,7 +97,8 @@

string16 failures = ASCIIToUTF16("Possibly conflicting modules:");

DictionaryValue* dictionary;

for (size_t i = 0; i < list->GetSize(); ++i) {

- list->GetDictionary(i, &dictionary);

+ if (!list->GetDictionary(i, &dictionary))

+ RecordFailure(ASCIIToUTF16("Dictionary lookup failed"));

int status;

string16 location;

string16 name;

« no previous file with comments | « no previous file | no next file » | no next file with comments »