Direct call api functions (arm implementation)

src/assembler.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 441 matching lines @@
 // External function
 
 //----------------------------------------------------------------------------
 class IC_Utility;
 class SCTableReference;
 #ifdef ENABLE_DEBUGGER_SUPPORT
 class Debug_Address;
 #endif
 
 
-typedef void* ExternalReferenceRedirector(void* original, bool fp_return);
-
-
 // An ExternalReference represents a C++ address used in the generated
 // code. All references to C++ functions and variables must be encapsulated in
 // an ExternalReference instance. This is done in order to track the origin of
 // all external references in the code so that they can be bound to the correct
 // addresses when deserializing a heap.
 class ExternalReference BASE_EMBEDDED {
  public:
+  // Used in the simulator to support different native api calls.
+  //
+  // BUILTIN_CALL - builtin/runtime call.

[Søren Thygesen Gjesse, 2011/02/02 13:24:38]

builtin/runtime -> builtin

[Zaheer, 2011/02/03 07:27:31]

Done.

+  // MaybeObject* f(v8::internal::Arguments).
+  //
+  // FP_CALL - builtin/runtime call that returns floating point.

[Søren Thygesen Gjesse, 2011/02/02 13:24:38]

Please change "builtin/runtime call that returns floating point." to something
like "direct call to a C-function which will never cause a GC". It is not always
a function with the signature double f(double, double), e.g.
"native_compare_doubles".

[Zaheer, 2011/02/03 07:27:31]

if iam not mistaken, native_compare_doubles uses the BUILTIN_CALL case and not
FP_RETURN case. In that sense isnt the current comment accurate?

[Søren Thygesen Gjesse, 2011/02/03 08:31:14]

You are right it does, and of cause returns an int. However it is rather
misleading to use BUILTIN_CALL, as the function is actually expecting two
doubles on the stack, but lets leave it like this for now.

One small thing though, the function power_double_double in assembler.cc should
be marked with FP_RETURN_CALL - it is currently wrongly missing the true
argument. It is not currently used on ARM, but probably will.

+  // double f(double, double).
+  //
+  // DIRECT_CALL - direct call to API function native callback
+  // from generated code.
+  // Handle<Value> f(v8::Arguments&)
+  //
+  enum Type {
+    BUILTIN_CALL,  // default
+    FP_RETURN_CALL,

[Søren Thygesen Gjesse, 2011/02/02 13:24:38]

FP_RETURN_CALL -> FP_CALL as in comment.

[Zaheer, 2011/02/03 07:27:31]

modified the comment to FP_RETURN_CALL to reflect the current naming. Let me
know if FP_CALL would be more accurate

+    DIRECT_CALL
+  };
+
+  typedef void* ExternalReferenceRedirector(void* original, Type type);
+
   explicit ExternalReference(Builtins::CFunctionId id);
 
-  explicit ExternalReference(ApiFunction* ptr);
+  explicit ExternalReference(ApiFunction* ptr, Type type);
 
   explicit ExternalReference(Builtins::Name name);
 
   explicit ExternalReference(Runtime::FunctionId id);
 
   explicit ExternalReference(Runtime::Function* f);
 
   explicit ExternalReference(const IC_Utility& ic_utility);
 
 #ifdef ENABLE_DEBUGGER_SUPPORT
@@ skipping 107 matching lines @@
     ASSERT(redirector_ == NULL);  // We can't stack them.
     redirector_ = redirector;
   }
 
  private:
   explicit ExternalReference(void* address)
       : address_(address) {}
 
   static ExternalReferenceRedirector* redirector_;
 
-  static void* Redirect(void* address, bool fp_return = false) {
+  static void* Redirect(void* address,
+                        Type type = ExternalReference::BUILTIN_CALL) {
     if (redirector_ == NULL) return address;
-    void* answer = (*redirector_)(address, fp_return);
+    void* answer = (*redirector_)(address, type);
     return answer;
   }
 
-  static void* Redirect(Address address_arg, bool fp_return = false) {
+  static void* Redirect(Address address_arg,
+                        Type type = ExternalReference::BUILTIN_CALL) {
     void* address = reinterpret_cast<void*>(address_arg);
     void* answer = (redirector_ == NULL) ?
                    address :
-                   (*redirector_)(address, fp_return);
+                   (*redirector_)(address, type);
     return answer;
   }
 
   void* address_;
 };
 
 
 // -----------------------------------------------------------------------------
 // Position recording support
 
@@ skipping 121 matching lines @@
   return num_bits_set;
 }
 
 // Computes pow(x, y) with the special cases in the spec for Math.pow.
 double power_double_int(double x, int y);
 double power_double_double(double x, double y);
 
 } }  // namespace v8::internal
 
 #endif  // V8_ASSEMBLER_H_