Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 6168001: Fix a bug that caused the site info bubble from a panel to be shown in a wrong location. (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
xiyuan, Daniel Erat
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a bug that caused the site info bubble from a panel to be shown in a wrong location. Before the fix, the bubble was shown under the location bar of the main browser window, rather than the location bar of the panel. The #ifdef'ed code was originally added in http://src.chromium.org/viewvc/chrome?view=rev&revision=46627 to fix crosbug.com/2783, but the code is no longer necessary: 1. We no longer have an issue that causes the site info popup to be shown full screen. In fact, the site info is now shown as a bubble. 2. We no longer show the location bar for the content browser (Ctrl-O) BUG=chromium-os:9022 TEST=confirmed that the location is fixed on the netbook. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
9 years, 11 months ago (2011-01-07 07:37:51 UTC) #1
xiyuan
9 years, 11 months ago (2011-01-07 18:04:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698