Issue 6165004: Refactor UpdatePrintableSizeInPrintParameters() function in print_web_view_helper.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6165004: Refactor UpdatePrintableSizeInPrintParameters() function in print_web_view_helper.cc (Closed)

Created:
9 years, 11 months ago by kmadhusu

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Refactor UpdatePrintableSizeInPrintParameters() function in print_web_view_helper.cc BUG=none TEST=printing works after code changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71186

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made code changes as per comments. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
	M	chrome/renderer/print_web_view_helper.cc	View	1	1 chunk	+22 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM with nit below. http://codereview.chromium.org/6165004/diff/1/chrome/renderer/print_web_view_helper.cc File chrome/renderer/print_web_view_helper.cc (right): http://codereview.chromium.org/6165004/diff/1/chrome/renderer/print_web_view_helper.cc#newcode371 chrome/renderer/print_web_view_helper.cc:371: int dpi = static_cast<int>(params->dpi); you ...

9 years, 11 months ago (2011-01-11 22:17:24 UTC) #2

kmadhusu

9 years, 11 months ago (2011-01-11 23:55:54 UTC) #3

Made code changes as per comments.

Thanks.

http://codereview.chromium.org/6165004/diff/1/chrome/renderer/print_web_view_...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/6165004/diff/1/chrome/renderer/print_web_view_...
chrome/renderer/print_web_view_helper.cc:371: int dpi =
static_cast<int>(params->dpi);
On 2011/01/11 22:17:25, Lei Zhang wrote:
> you can rewrite this as:
> 
> int dpi =
> #if defined(OS_MACOSX)
> ...
> #else
> ...
> #endif

Done.

Expand Messages | Collapse Messages