Issue 6164004: Optimize JSON stringify for arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6164004: Optimize JSON stringify for arrays. (Closed)

Created:
9 years, 11 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
chromium-reviews

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -14 lines)			Patch
	M	src/json.js	View	1 2	4 chunks	+49 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

http://codereview.chromium.org/6164004/diff/1/src/json.js File src/json.js (right): http://codereview.chromium.org/6164004/diff/1/src/json.js#newcode187 src/json.js:187: var val = value[0]; what if len is 0 ...

9 years, 11 months ago (2011-01-12 12:44:40 UTC) #2

sandholm

9 years, 11 months ago (2011-01-12 13:36:19 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 6164004: Optimize JSON stringify for arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages