plugins: drop PluginVersionInfo for internal plugins

webkit/plugins/npapi/plugin_lib_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/npapi/plugin_lib.h"
 
 #include "base/file_version_info.h"
 #include "base/file_version_info_win.h"
 #include "base/logging.h"
 #include "base/path_service.h"
@@ skipping 14 matching lines @@
       FileVersionInfo::CreateFileVersionInfo(filename));
   if (!version_info.get()) {
     LOG_IF(ERROR, PluginList::DebugPluginLoading())
         << "Could not get version info for plugin "
         << filename.value();
     return false;
   }
 
   FileVersionInfoWin* version_info_win =
       static_cast<FileVersionInfoWin*>(version_info.get());
-  PluginVersionInfo pvi;
-  pvi.mime_types = version_info_win->GetStringValue(L"MIMEType");
-  pvi.file_extensions = version_info_win->GetStringValue(L"FileExtents");
-  pvi.type_descriptions = version_info_win->GetStringValue(L"FileOpenName");
-  pvi.product_name = version_info->product_name();
-  pvi.file_description = version_info->file_description();
-  pvi.file_version = version_info->file_version();
-  pvi.path = filename;
 
-  return PluginList::CreateWebPluginInfo(pvi, info);
+  info->name = version_info->product_name();
+  info->desc = version_info->file_description();
+  info->version = version_info->file_version();
+  info->path = filename;
+  info->enabled = true;

[pastarmovj, 2011/01/13 13:36:08]

The way you set this flag here is correct.

The enabled flag should be per default set to true as you had it in
PluginList::CreateWebPluginInfo. This is because the code assumes plugins are
enabled until the user don't disable them or a policy enforces their disabled
state (which happens in the PluginsList::LoadPlugins.

This is anyway going to be tweaked by a refactoring plugin I am working on right
now but the change shouldn't concern this code.

+
+  // TODO(evan): Move the ParseMimeTypes code inline once Pepper is updated.
+  if (!PluginList::ParseMimeTypes(
+          version_info_win->GetStringValue(L"MIMEType"),
+          version_info_win->GetStringValue(L"FileExtents"),
+          version_info_win->GetStringValue(L"FileOpenName"),
+          &info->mime_types)) {
+    LOG_IF(ERROR, PluginList::DebugPluginLoading())
+        << "Plugin " << info->name << " has bad MIME types, skipping";
+    return false;
+  }
+
+  return true;
 }
 
 }  // namespace npapi
 }  // namespace webkit