Issue 6162004: Fix perf redness caused by an event name change. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6162004: Fix perf redness caused by an event name change. ... (Closed)

Created:
9 years, 11 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix perf redness caused by an event name change. TBR=amit BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70813

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/test/perf/chrome_frame_perftest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

9 years, 11 months ago (2011-01-08 00:39:05 UTC) #2

lg

On Fri, Jan 7, 2011 at 4:18 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix perf redness caused by an event name change.
>
> TBR=amit
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/6162004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/perf/chrome_frame_perftest.cc
>
>
> Index: chrome_frame/test/perf/chrome_frame_perftest.cc
> ===================================================================
> --- chrome_frame/test/perf/chrome_frame_perftest.cc     (revision 70377)
> +++ chrome_frame/test/perf/chrome_frame_perftest.cc     (working copy)
> @@ -1424,7 +1424,7 @@
>     automation_provider_connect_monitor[i].set_start_event(
>         "AutomationProvider::AutomationProvider");
>     automation_provider_connect_monitor[i].set_end_event(
> -        "AutomationProvider::ConnectToChannel");
> +        "AutomationProvider::InitializeChannel");
>
>     external_tab_navigate_monitor[i].set_interesting_event(
>         "ExternalTabContainer::Navigate");
>
>
>

Expand Messages | Collapse Messages