Remove duplicate members from some LIR instruction by using the HIR accessors...

Remove duplicate members from some LIR instruction by using the HIR accessors.

Remove unused LOperands from keyed-loads. We do not have multiple representations
for load instructions anymore.

Correct number of output operands as for a couple of instructions form 1 to 0
because they do not produce a result (e.g. PushArgument)


Committed: http://code.google.com/p/v8/source/detail?r=6258

[Kevin Millikin (Chromium), 2011-01-11 11:31:56]

LGTM.  I like to have precondition asserts all together at the start.

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc#newcode1695
src/arm/lithium-arm.cc:1695:
ASSERT(instr->key()->representation().IsInteger32());
Put this precondition assert right after the other one?

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h#newcode1246
src/arm/lithium-arm.h:1246: LOperand* key)
The line break between the arguments is no longer necessary?

http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc#newcod...
src/ia32/lithium-ia32.cc:1708:
ASSERT(instr->key()->representation().IsInteger32());
Move this assert up by the other one?

[fschneider, 2011-01-11 11:41:49]

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.cc#newcode1695
src/arm/lithium-arm.cc:1695:
ASSERT(instr->key()->representation().IsInteger32());
On 2011/01/11 11:31:56, Kevin Millikin wrote:
> Put this precondition assert right after the other one?

Done.

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):

http://codereview.chromium.org/6158004/diff/1/src/arm/lithium-arm.h#newcode1246
src/arm/lithium-arm.h:1246: LOperand* key)
On 2011/01/11 11:31:56, Kevin Millikin wrote:
> The line break between the arguments is no longer necessary?

Done.

http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6158004/diff/1/src/ia32/lithium-ia32.cc#newcod...
src/ia32/lithium-ia32.cc:1708:
ASSERT(instr->key()->representation().IsInteger32());
On 2011/01/11 11:31:56, Kevin Millikin wrote:
> Move this assert up by the other one?

Done.