Handle WM_SYSKEYDOWN in NativeTextfieldWin.

Handle WM_SYSKEYDOWN in NativeTextfieldWin.

BUG=69248
TEST=Manual: open find bar and hit alt on debug build.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71206

[Finnur, 2011-01-11 21:27:26]

http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
views/controls/textfield/native_textfield_win.cc:902: case WM_SYSKEYDOWN:
This would take care of the NOTREACHED, but I'm not sure what this means in the
grand scheme of things. Maybe the person who reviewed your big changelist that
introduced this should take a look?

[Finnur, 2011-01-11 21:28:17]

Actually, taking a second look, this is effectively not changing anything in
Release build and fixing the Debug build, so LGTM.

On 2011/01/11 21:27:26, Finnur wrote:
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> File views/controls/textfield/native_textfield_win.cc (right):
> 
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> views/controls/textfield/native_textfield_win.cc:902: case WM_SYSKEYDOWN:
> This would take care of the NOTREACHED, but I'm not sure what this means in
the
> grand scheme of things. Maybe the person who reviewed your big changelist that
> introduced this should take a look?

[Finnur, 2011-01-11 21:28:54]

http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
File views/controls/textfield/native_textfield_win.cc (right):

http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
views/controls/textfield/native_textfield_win.cc:906: case WM_KEYUP:
Will you not get WM_SYSKEYUP also?

[oshima, 2011-01-11 22:13:25]

On 2011/01/11 21:28:54, Finnur wrote:
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> File views/controls/textfield/native_textfield_win.cc (right):
> 
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> views/controls/textfield/native_textfield_win.cc:906: case WM_KEYUP:
> Will you not get WM_SYSKEYUP also?

DONE. Please take another look?

[Finnur, 2011-01-11 22:19:45]

Hmm... There is also WM_SYSCHAR...? 
:)

On 2011/01/11 22:13:25, oshima wrote:
> On 2011/01/11 21:28:54, Finnur wrote:
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > File views/controls/textfield/native_textfield_win.cc (right):
> > 
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > views/controls/textfield/native_textfield_win.cc:906: case WM_KEYUP:
> > Will you not get WM_SYSKEYUP also?
> 
> DONE. Please take another look?

[oshima, 2011-01-11 22:27:00]

On 2011/01/11 22:19:45, Finnur wrote:
> Hmm... There is also WM_SYSCHAR...? 
> :)

Done. any other?

> 
> On 2011/01/11 22:13:25, oshima wrote:
> > On 2011/01/11 21:28:54, Finnur wrote:
> > >
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > > File views/controls/textfield/native_textfield_win.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > > views/controls/textfield/native_textfield_win.cc:906: case WM_KEYUP:
> > > Will you not get WM_SYSKEYUP also?
> > 
> > DONE. Please take another look?

[Finnur, 2011-01-11 22:32:25]

Nope. I think that's it. LGTM.

On2011/01/11 22:27:00, oshima wrote:
> On 2011/01/11 22:19:45, Finnur wrote:
> > Hmm... There is also WM_SYSCHAR...? 
> > :)
> 
> Done. any other?
> 
> > 
> > On 2011/01/11 22:13:25, oshima wrote:
> > > On 2011/01/11 21:28:54, Finnur wrote:
> > > >
> > >
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > > > File views/controls/textfield/native_textfield_win.cc (right):
> > > > 
> > > >
> > >
> >
>
http://codereview.chromium.org/6156009/diff/1/views/controls/textfield/native...
> > > > views/controls/textfield/native_textfield_win.cc:906: case WM_KEYUP:
> > > > Will you not get WM_SYSKEYUP also?
> > > 
> > > DONE. Please take another look?