Implementing context menu for the new views textfield.

views/controls/textfield/native_textfield_views.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

[oshima, 2011/01/12 18:46:25]

2011  (other files too)

[varunjain, 2011/01/12 19:59:05]

These files were created in 2010... I think this is fine.

[tfarina, 2011/01/12 20:01:22]

No, you have to update the copyright here, when you change the code.

[oshima, 2011/01/12 21:01:47]

tfarina is correct. chrome updates the copyright when modified. This is one of a
few differences from google3.

[varunjain, 2011/01/12 21:28:11]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_
 #pragma once
 
+#include "app/menus/simple_menu_model.h"
 #include "base/string16.h"
 #include "base/task.h"
 #include "gfx/font.h"
 #include "views/border.h"
 #include "views/controls/textfield/native_textfield_wrapper.h"
 #include "views/view.h"
 
 namespace gfx {
 class Canvas;
 }  // namespace
 
 namespace views {
 
 class KeyEvent;
+class Menu2;
 class TextfieldViewsModel;
 
 // A views/skia only implementation of NativeTextfieldWrapper.
 // No platform specific code is used.
 // Following features are not yet supported.
 // * BIDI
 // * Context Menu.

[oshima, 2011/01/12 18:46:25]

remove this

[varunjain, 2011/01/12 19:59:05]

Done.

 // * IME/i18n support.
 // * X selection (only if we want to support).
 // * STYLE_MULTILINE, STYLE_LOWERCASE text. (These are not used in
 //   chromeos, so we may not need them)
 // * Double click to select word, and triple click to select all.
 // * Undo/Redo
 class NativeTextfieldViews : public views::View,
-                             public NativeTextfieldWrapper {
+                             public views::ContextMenuController,
+                             public NativeTextfieldWrapper,
+                             public menus::SimpleMenuModel::Delegate {
  public:
   explicit NativeTextfieldViews(Textfield* parent);
   ~NativeTextfieldViews();
 
   // views::View overrides:
   virtual bool OnMousePressed(const views::MouseEvent& e);
   virtual bool OnMouseDragged(const views::MouseEvent& e);
   virtual void OnMouseReleased(const views::MouseEvent& e, bool canceled);
   virtual bool OnKeyPressed(const views::KeyEvent& e);
   virtual bool OnKeyReleased(const views::KeyEvent& e);
   virtual void Paint(gfx::Canvas* canvas);
   virtual void DidChangeBounds(const gfx::Rect& previous,
                                const gfx::Rect& current);
   virtual void WillGainFocus();
   virtual void DidGainFocus();
   virtual void WillLoseFocus();
 
+  // views::ContextMenuController overrides:
+  virtual void ShowContextMenu(View* source,
+                               const gfx::Point& p,
+                               bool is_mouse_gesture);
+
   // NativeTextfieldWrapper overrides:
   virtual string16 GetText() const;
   virtual void UpdateText();
   virtual void AppendText(const string16& text);
   virtual string16 GetSelectedText() const;
   virtual void SelectAll();
   virtual void ClearSelection();
   virtual void UpdateBorder();
   virtual void UpdateTextColor();
   virtual void UpdateBackgroundColor();
   virtual void UpdateReadOnly();
   virtual void UpdateFont();
   virtual void UpdateIsPassword();
   virtual void UpdateEnabled();
   virtual gfx::Insets CalculateInsets();
   virtual void UpdateHorizontalMargins();
   virtual void UpdateVerticalMargins();
   virtual bool SetFocus();
   virtual View* GetView();
   virtual gfx::NativeView GetTestingHandle() const;
   virtual bool IsIMEComposing() const;
   virtual bool HandleKeyPressed(const views::KeyEvent& e);
   virtual bool HandleKeyReleased(const views::KeyEvent& e);
   virtual void HandleWillGainFocus();
   virtual void HandleDidGainFocus();
   virtual void HandleWillLoseFocus();
 
+  // menus::SimpleMenuModel::Delegate overrides
+  virtual bool IsCommandIdChecked(int command_id) const;
+  virtual bool IsCommandIdEnabled(int command_id) const;
+  virtual bool GetAcceleratorForCommandId(int command_id,
+                                          menus::Accelerator* accelerator);
+  virtual void ExecuteCommand(int command_id);
+
   // class name of internal
   static const char kViewClassName[];
 
   // Returns true when
   // 1) built with GYP_DEFIENS="touchui=1"
   // 2) enabled by SetEnableTextfieldViews(true)
   // 3) enabled by the command line flag "--enable-textfield-view".
   static bool IsTextfieldViewsEnabled();
   // Enable/Disable TextfieldViews implementation for Textfield.
   static void SetEnableTextfieldViews(bool enabled);
@@ skipping 45 matching lines @@
   // Handle the keyevent.
   bool HandleKeyEvent(const KeyEvent& key_event);
 
   // Utility function. Gets the character corresponding to a keyevent.
   // Returns 0 if the character is not printable.
   char16 GetPrintableChar(const KeyEvent& key_event);
 
   // Find a cusor position for given |point| in this views coordinates.
   size_t FindCursorPosition(const gfx::Point& point) const;
 
+  // Utility function to inform the parent textfield (and its controller if any)
+  // that the text in the textfield has changed.
+  void PropagateTextChange();
+
+  // Utility function to create the context menu.
+  void CreateContextMenu();

[oshima, 2011/01/12 18:46:25]

 CreateXXX is typically used to return instance, so I'd call it
"InitContextMenu'.

Or you can rename it to "EnsureContxtMenu" and include checks. This way, Test do
not have to check the scoped pointer.

[varunjain, 2011/01/12 19:59:05]

Changed to Init
Done

+
   // The parent textfield, the owner of this object.
   Textfield* textfield_;
 
   // The text model.
   scoped_ptr<TextfieldViewsModel> model_;
 
   // The reference to the border class. The object is owned by View::border_.
   TextfieldBorder* text_border_;
 
   // The x offset for the text to be drawn, without insets;
   int text_offset_;
 
   // Cursor's bounds in the textfield's coordinates.
   gfx::Rect cursor_bounds_;
 
   // True if the textfield is in insert mode.
   bool insert_;
 
   // The drawing state of cursor. True to draw.
   bool is_cursor_visible_;
 
   // A runnable method factory for callback to update the cursor.
   ScopedRunnableMethodFactory<NativeTextfieldViews> cursor_timer_;
 
+  // Context menu and its content list for the textfield.
+  scoped_ptr<menus::SimpleMenuModel> context_menu_contents_;
+  scoped_ptr<Menu2> context_menu_menu_;
+
   DISALLOW_COPY_AND_ASSIGN(NativeTextfieldViews);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_VIEWS_H_