Attempt to fix a chrome frame tests crash consistently seen on the IE9 builde...

Attempt to fix a chrome frame tests crash consistently seen on the IE9 builder. I was able to
reproduce it once and it appears to be occuring when the ListenSocket attempts to pass an
OnObjectSignaled notification to a delegate which is the web server which has already been destroyed

Attempted fix is to destroy the ListenSocket in the destructor of the web server.

BUG=none
TEST=Existing chrome frame tests.

TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71125

[amit, 2011-01-12 03:59:52]

lg, thanks for tracking this down.

On Tue, Jan 11, 2011 at 4:32 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Attempt to fix a chrome frame tests crash consistently seen on the IE9
> builder.
> I was able to
> reproduce it once and it appears to be occuring when the ListenSocket
> attempts
> to pass an
> OnObjectSignaled notification to a delegate which is the web server which
> has
> already been destroyed
>
> Attempted fix is to destroy the ListenSocket in the destructor of the web
> server.
>
> BUG=none
> TEST=Existing chrome frame tests.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6155009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/test_server.cc
>
>
> Index: chrome_frame/test/test_server.cc
> ===================================================================
> --- chrome_frame/test/test_server.cc    (revision 71071)
> +++ chrome_frame/test/test_server.cc    (working copy)
> @@ -237,6 +237,8 @@
>  }
>
>  HTTPTestServer::~HTTPTestServer() {
> +  LOG(INFO) << __FUNCTION__;
> +  server_ = NULL;
>  }
>
>  std::list<scoped_refptr<ConfigurableConnection>>::iterator
>
>
>