DOMUI: Implement the new Fonts and Encoding page.

chrome/browser/resources/shared/js/i18n_template.js

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This is a simple template engine inspired by JsTemplates
  * optimized for i18n.
  *
  * It currently supports two handlers:
  *
  *   * i18n-content which sets the textContent of the element
@@ skipping 25 matching lines @@
     'i18n-content': function(element, attributeValue, obj) {
       element.textContent = obj[attributeValue];
     },
 
     /**
      * This handler adds options to a select element.
      */
     'i18n-options': function(element, attributeValue, obj) {
       var options = obj[attributeValue];
       options.forEach(function(values) {
-        var option = typeof values == 'string' ? new Option(values) :
-            new Option(values[1], values[0]);
+        var option;
+        if (typeof values == 'string') {
+          element.dataType = 'string';

[arv (Not doing code reviews), 2011/01/11 21:50:35]

This is getting a bit out of hand. Why should i18n care about the data type?

[James Hawkins, 2011/01/11 23:45:54]

I've reverted this change and added handling for an undefined dataType to the
PrefSelect class.  PrefSelect now treats undefined dataType as a string.

+          option = new Option(values);
+        } else {
+          element.dataType = typeof values[0];
+          option = new Option(values[1], values[0]);
+        }
         element.appendChild(option);
       });
     },
 
     /**
      * This is used to set HTML attributes and DOM properties,. The syntax is:
      *   attributename:key;
      *   .domProperty:key;
      *   .nested.dom.property:key
      */
@@ skipping 52 matching lines @@
           handlers[name](element, att, obj);
         }
       }
     }
   }
 
   return {
     process: process
   };
 })();