Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: omaha_request_action.cc

Issue 6154003: AU: Reduce instances of signalling the crash reporter. (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master
Patch Set: fix for review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | update_attempter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_action.cc
diff --git a/omaha_request_action.cc b/omaha_request_action.cc
index bb2275d2f78e58389702854bb1348b7ebd18e888..7bb3d8bcdf4b5e797174d989508a84bd8276ac52 100644
--- a/omaha_request_action.cc
+++ b/omaha_request_action.cc
@@ -344,6 +344,11 @@ void OmahaRequestAction::TransferComplete(HttpFetcher *fetcher,
// Events are best effort transactions -- assume they always succeed.
if (IsEvent()) {
CHECK(!HasOutputPipe()) << "No output pipe allowed for event requests.";
+ if (event_->result == OmahaEvent::kResultError && successful &&
+ utils::IsOfficialBuild()) {
+ LOG(INFO) << "Signalling Crash Reporter.";
+ utils::ScheduleCrashReporterUpload();
+ }
completer.set_code(kActionCodeSuccess);
return;
}
« no previous file with comments | « no previous file | update_attempter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698