Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: update_attempter.cc

Issue 6154003: AU: Reduce instances of signalling the crash reporter. (Closed) Base URL: http://git.chromium.org/git/update_engine.git@master
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« omaha_request_action.cc ('K') | « omaha_request_action_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: update_attempter.cc
diff --git a/update_attempter.cc b/update_attempter.cc
index a63a1e86e910a8e211c1df90a37f961a7a165edd..2791f675dad3dbd9007ea9b3bb937d718de8a9ee 100644
--- a/update_attempter.cc
+++ b/update_attempter.cc
@@ -282,8 +282,11 @@ void UpdateAttempter::ProcessingDone(const ActionProcessor* processor,
if (status_ == UPDATE_STATUS_REPORTING_ERROR_EVENT) {
LOG(INFO) << "Error event sent.";
- // Tell crash reporter there was a problem.
- utils::ScheduleCrashReporterUpload();
+ if (utils::IsOfficialBuild() && code == kActionCodeSuccess) {
+ LOG(INFO) << "Signalling crash reporter.";
+ // Tell crash reporter there was a problem.
+ utils::ScheduleCrashReporterUpload();
+ }
SetStatusAndNotify(UPDATE_STATUS_IDLE);
return;
}
« omaha_request_action.cc ('K') | « omaha_request_action_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698