Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4707)

Unified Diff: chrome/installer/util/installation_state.h

Issue 6153003: Refactor install.cc into the work item parts and the non-work item parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/installation_state.h
===================================================================
--- chrome/installer/util/installation_state.h (revision 70610)
+++ chrome/installer/util/installation_state.h (working copy)
@@ -55,22 +55,15 @@
// Returns the state of the multi-installer package or NULL if no
// multi-install products are installed.
+ // Caller does NOT assume ownership of returned pointer.
tommi (sloooow) - chröme 2011/01/12 19:02:49 since the returned pointer is const, I presume you
grt (UTC plus 2) 2011/01/12 19:23:57 C++-03 5.3.5.2: Note: a pointer to a const type ca
robertshield 2011/01/13 17:06:32 Done.
robertshield 2011/01/13 17:06:32 What Greg said ;-)
const ProductState* GetMultiPackageState(bool system_install) const;
- // Sets the state of the multi-installer package; intended for tests.
- void SetMultiPackageState(bool system_install,
- const ProductState& package_state);
-
// Returns the state of a product or NULL if not installed.
+ // Caller does NOT assume ownership of returned pointer.
tommi (sloooow) - chröme 2011/01/12 19:02:49 same here
robertshield 2011/01/13 17:06:32 Done.
const ProductState* GetProductState(bool system_install,
BrowserDistribution::Type type) const;
- // Sets the state of a product; indended for tests.
- void SetProductState(bool system_install,
- BrowserDistribution::Type type,
- const ProductState& product_state);
-
- private:
+ protected:
enum {
CHROME_BROWSER_INDEX,
CHROME_FRAME_INDEX,

Powered by Google App Engine
This is Rietveld 408576698