Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: chrome/chrome_installer.gypi

Issue 6153003: Refactor install.cc into the work item parts and the non-work item parts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE', 7 'lastchange_path': '<(SHARED_INTERMEDIATE_DIR)/build/LASTCHANGE',
8 # 'branding_dir' is set in the 'conditions' section at the bottom. 8 # 'branding_dir' is set in the 'conditions' section at the bottom.
9 }, 9 },
10 'conditions': [ 10 'conditions': [
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 ], 199 ],
200 'direct_dependent_settings': { 200 'direct_dependent_settings': {
201 'include_dirs': [ 201 'include_dirs': [
202 '<(SHARED_INTERMEDIATE_DIR)/setup', 202 '<(SHARED_INTERMEDIATE_DIR)/setup',
203 ], 203 ],
204 }, 204 },
205 'sources': [ 205 'sources': [
206 'installer/mini_installer/chrome.release', 206 'installer/mini_installer/chrome.release',
207 'installer/setup/install.cc', 207 'installer/setup/install.cc',
208 'installer/setup/install.h', 208 'installer/setup/install.h',
209 'installer/setup/install_worker.cc',
210 'installer/setup/install_worker.h',
209 'installer/setup/setup_main.cc', 211 'installer/setup/setup_main.cc',
210 'installer/setup/setup.ico', 212 'installer/setup/setup.ico',
211 'installer/setup/setup.rc', 213 'installer/setup/setup.rc',
212 'installer/setup/setup_constants.cc', 214 'installer/setup/setup_constants.cc',
213 'installer/setup/setup_constants.h', 215 'installer/setup/setup_constants.h',
214 'installer/setup/setup_exe_version.rc.version', 216 'installer/setup/setup_exe_version.rc.version',
215 'installer/setup/setup_resource.h', 217 'installer/setup/setup_resource.h',
216 'installer/setup/setup_util.cc', 218 'installer/setup/setup_util.cc',
217 'installer/setup/setup_util.h', 219 'installer/setup/setup_util.h',
218 'installer/setup/uninstall.cc', 220 'installer/setup/uninstall.cc',
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 { 304 {
303 'target_name': 'setup_unittests', 305 'target_name': 'setup_unittests',
304 'type': 'executable', 306 'type': 'executable',
305 'msvs_guid': 'C0AE4E06-F023-460F-BC14-6302CEAC51F8', 307 'msvs_guid': 'C0AE4E06-F023-460F-BC14-6302CEAC51F8',
306 'dependencies': [ 308 'dependencies': [
307 'installer_util', 309 'installer_util',
308 '<(DEPTH)/base/base.gyp:base', 310 '<(DEPTH)/base/base.gyp:base',
309 '<(DEPTH)/base/base.gyp:base_i18n', 311 '<(DEPTH)/base/base.gyp:base_i18n',
310 '<(DEPTH)/base/base.gyp:test_support_base', 312 '<(DEPTH)/base/base.gyp:test_support_base',
311 '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl', 313 '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl',
314 '<(DEPTH)/testing/gmock.gyp:gmock',
312 '<(DEPTH)/testing/gtest.gyp:gtest', 315 '<(DEPTH)/testing/gtest.gyp:gtest',
313 ], 316 ],
314 'include_dirs': [ 317 'include_dirs': [
315 '<(DEPTH)', 318 '<(DEPTH)',
316 ], 319 ],
320 # TODO(robertshield): Move the items marked with "Move to lib"
321 # below into a separate lib and then link both setup.exe and
322 # setup_unittests.exe against that.
317 'sources': [ 323 'sources': [
324 'installer/setup/install_worker.cc', # Move to lib
325 'installer/setup/install_worker.h', # Move to lib
326 'installer/setup/install_worker_unittest.cc',
318 'installer/setup/run_all_unittests.cc', 327 'installer/setup/run_all_unittests.cc',
328 'installer/setup/setup_constants.cc', # Move to lib
329 'installer/setup/setup_constants.h', # Move to lib
319 'installer/setup/setup_util.cc', 330 'installer/setup/setup_util.cc',
320 'installer/setup/setup_util_unittest.cc', 331 'installer/setup/setup_util_unittest.cc',
321 ], 332 ],
322 }, 333 },
323 ], 334 ],
324 }], 335 }],
325 ['OS=="linux" and branding=="Chrome"', { 336 ['OS=="linux" and branding=="Chrome"', {
326 'variables': { 337 'variables': {
327 # Always google_chrome since this only applies to branding==Chrome. 338 # Always google_chrome since this only applies to branding==Chrome.
328 'branding_dir': 'app/theme/google_chrome', 339 'branding_dir': 'app/theme/google_chrome',
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 }, 881 },
871 }], 882 }],
872 ], 883 ],
873 } 884 }
874 885
875 # Local Variables: 886 # Local Variables:
876 # tab-width:2 887 # tab-width:2
877 # indent-tabs-mode:nil 888 # indent-tabs-mode:nil
878 # End: 889 # End:
879 # vim: set expandtab tabstop=2 shiftwidth=2: 890 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/setup/install.h » ('j') | chrome/installer/setup/install_worker.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698