Issue 6153002: Start counting at 1 for extension API validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6153002: Start counting at 1 for extension API validation. (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, pam+watch_chromium.org, Erik does not do reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/renderer/resources

Visibility:
Public.

Description

Start counting at 1 for extension API validation. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70774

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/renderer/resources/extension_process_bindings.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

On 2011/01/07 15:43:01, jochen wrote: > please review LGTM, but I'm surprised this doesn't break ...

9 years, 11 months ago (2011-01-07 19:18:02 UTC) #2

jochen (gone - plz use gerrit)

9 years, 11 months ago (2011-01-07 19:58:10 UTC) #3

On 2011/01/07 19:18:02, Aaron Boodman wrote:
> On 2011/01/07 15:43:01, jochen wrote:
> > please review
> 
> LGTM, but I'm surprised this doesn't break any tests. Did you try running
> browser_tests --gtest_filter=Extension* ?

You removed the tests that covered this code in
http://codereview.chromium.org/2847008 :)

Expand Messages | Collapse Messages