Issue 6152007: Fix and re-enable RenderViewTest.MacTestCmdUp (we need to spin the message lo...

Issue 6152007: Fix and re-enable RenderViewTest.MacTestCmdUp (we need to spin the message lo... (Closed)

Created:
9 years, 11 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix and re-enable RenderViewTest.MacTestCmdUp (we need to spin the message loop since scroll events are asynchronous as of http://trac.webkit.org/changeset/75555/). BUG=69349 TEST=RenderViewTest.MacTestCmdUp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71255

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/renderer/render_view_browsertest_mac.mm	View		5 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 11 months ago (2011-01-12 22:09:43 UTC) #2

LG

On Wed, Jan 12, 2011 at 2:08 PM,  <mihaip@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Fix and re-enable RenderViewTest.MacTestCmdUp (we need to spin the message
> loop
> since scroll events are asynchronous as of
> http://trac.webkit.org/changeset/75555/).
>
> BUG=69349
> TEST=RenderViewTest.MacTestCmdUp
>
> Please review this at http://codereview.chromium.org/6152007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/renderer/render_view_browsertest_mac.mm
>
>
> Index: chrome/renderer/render_view_browsertest_mac.mm
> ===================================================================
> --- chrome/renderer/render_view_browsertest_mac.mm      (revision 71187)
> +++ chrome/renderer/render_view_browsertest_mac.mm      (working copy)
> @@ -39,7 +39,7 @@
>
>  // Test that cmd-up/down scrolls the page exactly if it is not intercepted
> by
>  // javascript.
> -TEST_F(RenderViewTest, DISABLED_MacTestCmdUp) {
> +TEST_F(RenderViewTest, MacTestCmdUp) {
>   // Some preprocessor trickery so that we can have literal html in our
> source,
>   // makes it easier to copy html to and from an html file for testing (the
>   // preprocessor will remove the newlines at the line ends, turning this
> into
> @@ -98,6 +98,7 @@
>   view_->OnSetEditCommandsForNextKeyEvent(
>       EditCommands(1, EditCommand("moveToEndOfDocument", "")));
>   SendNativeKeyEvent(NativeWebKeyboardEvent(arrowDownKeyDown));
> +  ProcessPendingMessages();
>   output = GetMainFrame()->contentAsText(kMaxOutputCharacters);
>   EXPECT_EQ(kArrowDownScrollDown, UTF16ToASCII(output));
>
> @@ -106,6 +107,7 @@
>   view_->OnSetEditCommandsForNextKeyEvent(
>       EditCommands(1, EditCommand("moveToBeginningOfDocument", "")));
>   SendNativeKeyEvent(NativeWebKeyboardEvent(arrowUpKeyDown));
> +  ProcessPendingMessages();
>   output = GetMainFrame()->contentAsText(kMaxOutputCharacters);
>   EXPECT_EQ(kArrowUpScrollUp, UTF16ToASCII(output));
>
> @@ -121,6 +123,7 @@
>   view_->OnSetEditCommandsForNextKeyEvent(
>       EditCommands(1, EditCommand("moveToEndOfDocument", "")));
>   SendNativeKeyEvent(NativeWebKeyboardEvent(arrowDownKeyDown));
> +  ProcessPendingMessages();
>   output = GetMainFrame()->contentAsText(kMaxOutputCharacters);
>   EXPECT_EQ(kArrowDownNoScroll, UTF16ToASCII(output));
>
> @@ -129,6 +132,7 @@
>   view_->OnSetEditCommandsForNextKeyEvent(
>       EditCommands(1, EditCommand("moveToBeginningOfDocument", "")));
>   SendNativeKeyEvent(NativeWebKeyboardEvent(arrowUpKeyDown));
> +  ProcessPendingMessages();
>   output = GetMainFrame()->contentAsText(kMaxOutputCharacters);
>   EXPECT_EQ(kArrowUpNoScroll, UTF16ToASCII(output));
>  }
>
>
>

Expand Messages | Collapse Messages