Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: chrome/installer/util/google_chrome_distribution_dummy.cc

Issue 6152003: Get rid of FilePath::FromWStringHack from google_chrome_distribution.[cc,h]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines dummy implementation of several functions from the 5 // This file defines dummy implementation of several functions from the
6 // BrowserDistribution class for Google Chrome. These functions allow 64-bit 6 // BrowserDistribution class for Google Chrome. These functions allow 64-bit
7 // Windows Chrome binary to build successfully. Since this binary is only used 7 // Windows Chrome binary to build successfully. Since this binary is only used
8 // for Native Client support, most of the install/uninstall functionality is not 8 // for Native Client support, most of the install/uninstall functionality is not
9 // necessary there. 9 // necessary there.
10 10
11 #include "chrome/installer/util/google_chrome_distribution.h" 11 #include "chrome/installer/util/google_chrome_distribution.h"
12 12
13 #include <windows.h> 13 #include <windows.h>
14 14
15 #include "base/file_path.h"
15 #include "base/logging.h" 16 #include "base/logging.h"
16 17
17 GoogleChromeDistribution::GoogleChromeDistribution( 18 GoogleChromeDistribution::GoogleChromeDistribution(
18 const installer::MasterPreferences& prefs) 19 const installer::MasterPreferences& prefs)
19 : BrowserDistribution(prefs) { 20 : BrowserDistribution(prefs) {
20 } 21 }
21 22
22 void GoogleChromeDistribution::DoPostUninstallOperations( 23 void GoogleChromeDistribution::DoPostUninstallOperations(
23 const Version& version, 24 const Version& version,
24 const FilePath& local_data_path, 25 const FilePath& local_data_path,
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 const installer::Product& installation, bool system_level) { 112 const installer::Product& installation, bool system_level) {
112 NOTREACHED(); 113 NOTREACHED();
113 } 114 }
114 115
115 void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor, 116 void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,
116 const installer::Product& installation) { 117 const installer::Product& installation) {
117 NOTREACHED(); 118 NOTREACHED();
118 } 119 }
119 120
120 bool GoogleChromeDistribution::ExtractUninstallMetricsFromFile( 121 bool GoogleChromeDistribution::ExtractUninstallMetricsFromFile(
121 const std::wstring& file_path, std::wstring* uninstall_metrics_string) { 122 const FilePath& file_path, std::wstring* uninstall_metrics_string) {
122 NOTREACHED(); 123 NOTREACHED();
123 return false; 124 return false;
124 } 125 }
125 126
126 bool GoogleChromeDistribution::ExtractUninstallMetrics( 127 bool GoogleChromeDistribution::ExtractUninstallMetrics(
127 const DictionaryValue& root, std::wstring* uninstall_metrics_string) { 128 const DictionaryValue& root, std::wstring* uninstall_metrics_string) {
128 NOTREACHED(); 129 NOTREACHED();
129 return false; 130 return false;
130 } 131 }
131 132
132 bool GoogleChromeDistribution::BuildUninstallMetricsString( 133 bool GoogleChromeDistribution::BuildUninstallMetricsString(
133 DictionaryValue* uninstall_metrics_dict, std::wstring* metrics) { 134 DictionaryValue* uninstall_metrics_dict, std::wstring* metrics) {
134 NOTREACHED(); 135 NOTREACHED();
135 return false; 136 return false;
136 } 137 }
137 138
138 bool GoogleChromeDistribution::SetChannelFlags( 139 bool GoogleChromeDistribution::SetChannelFlags(
139 bool set, 140 bool set,
140 installer::ChannelInfo* channel_info) { 141 installer::ChannelInfo* channel_info) {
141 NOTREACHED(); 142 NOTREACHED();
142 return false; 143 return false;
143 } 144 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698