Issue 6152001: Makes instant not supress infobars. As part of this I'm removing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6152001: Makes instant not supress infobars. As part of this I'm removing (Closed)

Created:
9 years, 11 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Makes instant not supress infobars. As part of this I'm removing unnecessary overrides in instant's TabContentsDelegate implementation. BUG=68540 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70739

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -53 lines)			Patch
	M	chrome/browser/instant/instant_loader.cc	View		4 chunks	+0 lines, -53 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/6152001/diff/1/chrome/browser/instant/instant_loader.cc File chrome/browser/instant/instant_loader.cc (left): http://codereview.chromium.org/6152001/diff/1/chrome/browser/instant/instant_loader.cc#oldcode372 chrome/browser/instant/instant_loader.cc:372: virtual bool infobars_enabled() { return false; } Sorry, I ...

9 years, 11 months ago (2011-01-06 23:59:51 UTC) #3

LGTM

Expand Messages | Collapse Messages