Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5908)

Unified Diff: chrome/renderer/speech_input_dispatcher.h

Issue 6151011: Introduce RenderView::Observer interface so that RenderView doesn't have to k... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view_observer.cc ('k') | chrome/renderer/speech_input_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/speech_input_dispatcher.h
===================================================================
--- chrome/renderer/speech_input_dispatcher.h (revision 71253)
+++ chrome/renderer/speech_input_dispatcher.h (working copy)
@@ -7,28 +7,26 @@
#include "base/basictypes.h"
#include "chrome/common/speech_input_result.h"
-#include "ipc/ipc_channel.h"
+#include "chrome/renderer/render_view_observer.h"
#include "third_party/WebKit/WebKit/chromium/public/WebSpeechInputController.h"
class GURL;
-class RenderView;
namespace WebKit {
class WebSpeechInputListener;
-class WebString;
-struct WebRect;
}
// SpeechInputDispatcher is a delegate for speech input messages used by WebKit.
// It's the complement of SpeechInputDispatcherHost (owned by RenderViewHost).
-class SpeechInputDispatcher : public WebKit::WebSpeechInputController,
- public IPC::Channel::Listener {
+class SpeechInputDispatcher : public RenderViewObserver,
+ public WebKit::WebSpeechInputController {
public:
SpeechInputDispatcher(RenderView* render_view,
WebKit::WebSpeechInputListener* listener);
- // IPC::Channel::Listener implementation.
- bool OnMessageReceived(const IPC::Message& msg);
+ private:
+ // RenderView::Observer implementation.
+ bool OnMessageReceived(const IPC::Message& message);
// WebKit::WebSpeechInputController.
virtual bool startRecognition(int request_id,
@@ -39,13 +37,11 @@
virtual void cancelRecognition(int request_id);
virtual void stopRecording(int request_id);
- private:
void OnSpeechRecognitionResult(
int request_id, const speech_input::SpeechInputResultArray& result);
void OnSpeechRecordingComplete(int request_id);
void OnSpeechRecognitionComplete(int request_id);
- RenderView* render_view_;
WebKit::WebSpeechInputListener* listener_;
DISALLOW_COPY_AND_ASSIGN(SpeechInputDispatcher);
Property changes on: chrome\renderer\speech_input_dispatcher.h
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/renderer/render_view_observer.cc ('k') | chrome/renderer/speech_input_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698