Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4950)

Unified Diff: chrome/renderer/geolocation_dispatcher.h

Issue 6151011: Introduce RenderView::Observer interface so that RenderView doesn't have to k... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/devtools_client.cc ('k') | chrome/renderer/geolocation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/geolocation_dispatcher.h
===================================================================
--- chrome/renderer/geolocation_dispatcher.h (revision 71253)
+++ chrome/renderer/geolocation_dispatcher.h (working copy)
@@ -7,10 +7,10 @@
#pragma once
#include "base/scoped_ptr.h"
+#include "chrome/renderer/render_view_observer.h"
#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationClient.h"
#include "third_party/WebKit/WebKit/chromium/public/WebGeolocationController.h"
-class RenderView;
struct Geoposition;
namespace WebKit {
@@ -21,19 +21,17 @@
class WebSecurityOrigin;
}
-namespace IPC {
-class Message;
-}
-
// GeolocationDispatcher is a delegate for Geolocation messages used by
// WebKit.
// It's the complement of GeolocationDispatcherHost (owned by RenderViewHost).
-class GeolocationDispatcher : public WebKit::WebGeolocationClient {
+class GeolocationDispatcher : public RenderViewObserver,
+ public WebKit::WebGeolocationClient {
public:
explicit GeolocationDispatcher(RenderView* render_view);
virtual ~GeolocationDispatcher();
- // IPC
+ private:
+ // RenderView::Observer implementation.
bool OnMessageReceived(const IPC::Message& message);
// WebGeolocationClient
@@ -48,7 +46,6 @@
virtual void cancelPermissionRequest(
const WebKit::WebGeolocationPermissionRequest& permissionRequest);
- private:
// Permission for using geolocation has been set.
void OnGeolocationPermissionSet(int bridge_id, bool is_allowed);
Property changes on: chrome\renderer\geolocation_dispatcher.h
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/renderer/devtools_client.cc ('k') | chrome/renderer/geolocation_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698