Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4192)

Unified Diff: chrome/renderer/devtools_client.h

Issue 6151011: Introduce RenderView::Observer interface so that RenderView doesn't have to k... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/devtools_agent.cc ('k') | chrome/renderer/devtools_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/devtools_client.h
===================================================================
--- chrome/renderer/devtools_client.h (revision 71253)
+++ chrome/renderer/devtools_client.h (working copy)
@@ -10,11 +10,10 @@
#include "base/basictypes.h"
#include "base/scoped_ptr.h"
-#include "ipc/ipc_channel.h"
+#include "chrome/renderer/render_view_observer.h"
#include "third_party/WebKit/WebKit/chromium/public/WebDevToolsFrontendClient.h"
class MessageLoop;
-class RenderView;
namespace WebKit {
class WebDevToolsFrontend;
@@ -29,14 +28,15 @@
// corresponding DevToolsAgent object.
// TODO(yurys): now the client is almost empty later it will delegate calls to
// code in glue
-class DevToolsClient : public WebKit::WebDevToolsFrontendClient,
- public IPC::Channel::Listener {
+class DevToolsClient : public RenderViewObserver,
+ public WebKit::WebDevToolsFrontendClient {
public:
- explicit DevToolsClient(RenderView* view);
+ explicit DevToolsClient(RenderView* render_view);
virtual ~DevToolsClient();
- // IPC::Channel::Listener implementation.
- bool OnMessageReceived(const IPC::Message& message);
+ private:
+ // RenderView::Observer implementation.
+ virtual bool OnMessageReceived(const IPC::Message& message);
// WebDevToolsFrontendClient implementation
virtual void sendFrontendLoaded();
@@ -50,13 +50,11 @@
virtual bool shouldHideScriptsPanel();
- private:
void OnDispatchOnInspectorFrontend(const std::string& message);
// Sends message to DevToolsAgent.
- void Send(const IPC::Message& tools_agent_message);
+ void SendToAgent(const IPC::Message& tools_agent_message);
- RenderView* render_view_; // host render view
scoped_ptr<WebKit::WebDevToolsFrontend> web_tools_frontend_;
DISALLOW_COPY_AND_ASSIGN(DevToolsClient);
« no previous file with comments | « chrome/renderer/devtools_agent.cc ('k') | chrome/renderer/devtools_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698