Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7685)

Unified Diff: chrome/renderer/device_orientation_dispatcher.h

Issue 6151011: Introduce RenderView::Observer interface so that RenderView doesn't have to k... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/autofill_helper.cc ('k') | chrome/renderer/device_orientation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/device_orientation_dispatcher.h
===================================================================
--- chrome/renderer/device_orientation_dispatcher.h (revision 71253)
+++ chrome/renderer/device_orientation_dispatcher.h (working copy)
@@ -8,21 +8,21 @@
#include "third_party/WebKit/WebKit/chromium/public/WebDeviceOrientationClient.h"
#include "base/scoped_ptr.h"
-#include "ipc/ipc_channel.h"
+#include "chrome/renderer/render_view_observer.h"
-class RenderView;
namespace WebKit { class WebDeviceOrientation; }
struct ViewMsg_DeviceOrientationUpdated_Params;
-class DeviceOrientationDispatcher : public WebKit::WebDeviceOrientationClient,
- public IPC::Channel::Listener {
+class DeviceOrientationDispatcher : public RenderViewObserver,
+ public WebKit::WebDeviceOrientationClient {
public:
- explicit DeviceOrientationDispatcher(RenderView* render_view);
+ DeviceOrientationDispatcher(RenderView* render_view);
virtual ~DeviceOrientationDispatcher();
- // IPC::Channel::Implementation.
- bool OnMessageReceived(const IPC::Message& msg);
+ private:
+ // RenderView::Observer implementation.
+ bool OnMessageReceived(const IPC::Message& message);
// From WebKit::WebDeviceOrientationClient.
virtual void setController(
@@ -31,11 +31,9 @@
virtual void stopUpdating();
virtual WebKit::WebDeviceOrientation lastOrientation() const;
- private:
void OnDeviceOrientationUpdated(
const ViewMsg_DeviceOrientationUpdated_Params& p);
- RenderView* render_view_;
scoped_ptr<WebKit::WebDeviceOrientationController> controller_;
scoped_ptr<WebKit::WebDeviceOrientation> last_orientation_;
bool started_;
« no previous file with comments | « chrome/renderer/autofill_helper.cc ('k') | chrome/renderer/device_orientation_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698