Introduce RenderView::Observer interface so that RenderView doesn't have to k...

chrome/renderer/render_view_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 
 #include "app/keyboard_codes.h"
 #include "base/file_util.h"
 #include "base/shared_memory.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/native_web_keyboard_event.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/render_messages_params.h"
+#include "chrome/renderer/autofill_helper.h"
 #include "chrome/renderer/print_web_view_helper.h"
 #include "chrome/test/render_view_test.h"
 #include "gfx/codec/jpeg_codec.h"
 #include "net/base/net_errors.h"
 #include "printing/image.h"
 #include "printing/native_metafile.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebInputElement.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebString.h"
@@ skipping 992 matching lines @@
   view_->set_send_content_state_immediately(true);
 
   LoadHTML("<form method=\"POST\">"
            "  <input type=\"text\" id=\"firstname\"/>"
            "  <input type=\"text\" id=\"middlename\" autoComplete=\"off\"/>"
            "  <input type=\"hidden\" id=\"lastname\"/>"
            "</form>");
 
   // Verify that "FormsSeen" sends the expected number of fields.
   ProcessPendingMessages();
-  const IPC::Message* message = render_thread_.sink().GetUniqueMessageMatching(
+  const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
       ViewHostMsg_FormsSeen::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
   ViewHostMsg_FormsSeen::Param params;
   ViewHostMsg_FormsSeen::Read(message, &params);
   const std::vector<FormData>& forms = params.a;
   ASSERT_EQ(1UL, forms.size());
   ASSERT_EQ(3UL, forms[0].fields.size());
   EXPECT_TRUE(forms[0].fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
@@ skipping 19 matching lines @@
   // Verify that |didAcceptAutoFillSuggestion()| sends the expected number of
   // fields.
   WebFrame* web_frame = GetMainFrame();
   WebDocument document = web_frame->document();
   WebInputElement firstname =
       document.getElementById("firstname").to<WebInputElement>();
 
   // Accept suggestion that contains a label.  Labeled items indicate AutoFill
   // as opposed to Autocomplete.  We're testing this distinction below with
   // the |ViewHostMsg_FillAutoFillFormData::ID| message.
-  view_->didAcceptAutoFillSuggestion(firstname,
-                                     WebKit::WebString::fromUTF8("Johnny"),
-                                     WebKit::WebString::fromUTF8("Home"),
-                                     1,
-                                     -1);
+  autofill_helper_->didAcceptAutoFillSuggestion(
+      firstname,
+      WebKit::WebString::fromUTF8("Johnny"),
+      WebKit::WebString::fromUTF8("Home"),
+      1,
+      -1);
 
   ProcessPendingMessages();
   const IPC::Message* message2 = render_thread_.sink().GetUniqueMessageMatching(
       ViewHostMsg_FillAutoFillFormData::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message2);
   ViewHostMsg_FillAutoFillFormData::Param params2;
   ViewHostMsg_FillAutoFillFormData::Read(message2, &params2);
   const FormData& form2 = params2.b;
   ASSERT_EQ(3UL, form2.fields.size());
   EXPECT_TRUE(form2.fields[0].StrictlyEqualsHack(
@@ skipping 25 matching lines @@
   // loop, it will generate an update.
   view_->set_send_content_state_immediately(true);
 
   LoadHTML("<form method=\"POST\">"
            "  <input type=\"text\" id=\"firstname\"/>"
            "  <input type=\"text\" id=\"middlename\"/>"
            "</form>");
 
   // Verify that "FormsSeen" sends the expected number of fields.
   ProcessPendingMessages();
-  const IPC::Message* message = render_thread_.sink().GetUniqueMessageMatching(
+  const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
       ViewHostMsg_FormsSeen::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
   ViewHostMsg_FormsSeen::Param params;
   ViewHostMsg_FormsSeen::Read(message, &params);
   const std::vector<FormData>& forms = params.a;
   ASSERT_EQ(1UL, forms.size());
   ASSERT_EQ(2UL, forms[0].fields.size());
   EXPECT_TRUE(forms[0].fields[0].StrictlyEqualsHack(
       FormField(string16(),
                 ASCIIToUTF16("firstname"),
@@ skipping 14 matching lines @@
   WebFrame* web_frame = GetMainFrame();
   WebDocument document = web_frame->document();
   WebInputElement firstname =
       document.getElementById("firstname").to<WebInputElement>();
   WebInputElement middlename =
       document.getElementById("middlename").to<WebInputElement>();
   middlename.setAutofilled(true);
 
   // Accept a suggestion in a form that has been auto-filled.  This triggers
   // the direct filling of the firstname element with value parameter.
-  view_->didAcceptAutoFillSuggestion(firstname,
-                                     WebKit::WebString::fromUTF8("David"),
-                                     WebKit::WebString(),
-                                     0,
-                                     0);
+  autofill_helper_->didAcceptAutoFillSuggestion(
+      firstname,
+      WebKit::WebString::fromUTF8("David"),
+      WebKit::WebString(),
+      0,
+      0);
 
   ProcessPendingMessages();
   const IPC::Message* message2 = render_thread_.sink().GetUniqueMessageMatching(
       ViewHostMsg_FillAutoFillFormData::ID);
 
   // No message should be sent in this case.  |firstname| is filled directly.
   ASSERT_EQ(static_cast<IPC::Message*>(NULL), message2);
   EXPECT_EQ(firstname.value(), WebKit::WebString::fromUTF8("David"));
 }
 
@@ skipping 58 matching lines @@
   LoadHTML("<html><head><meta http-equiv=\"content-language\" "
            "content=\" fr , es,en \">"
            "</head><body>A random page with random content.</body></html>");
   ProcessPendingMessages();
   message = render_thread_.sink().GetUniqueMessageMatching(
       ViewHostMsg_PageContents::ID);
   ASSERT_NE(static_cast<IPC::Message*>(NULL), message);
   ViewHostMsg_PageContents::Read(message, &params);
   EXPECT_EQ("fr", params.d);
 }