Introduce RenderView::Observer interface so that RenderView doesn't have to k...

chrome/renderer/password_autocomplete_manager_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/keyboard_codes.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/renderer/autofill_helper.h"
 #include "chrome/renderer/password_autocomplete_manager.h"
 #include "chrome/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebElement.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebFormElement.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebInputElement.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebNode.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebString.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebVector.h"
@@ skipping 37 matching lines @@
  public:
   PasswordAutocompleteManagerTest() {
   }
 
   // Simulates the fill password form message being sent to the renderer.
   // We use that so we don't have to make RenderView::OnFillPasswordForm()
   // protected.
   void SimulateOnFillPasswordForm(
       const PasswordFormFillData& fill_data) {
     ViewMsg_FillPasswordForm msg(0, fill_data);
-    view_->OnMessageReceived(msg);
+    password_autocomplete_->OnMessageReceived(msg);
   }
 
   virtual void SetUp() {
     RenderViewTest::SetUp();
 
     // Add a preferred login and an additional login to the FillData.
     username1_ = ASCIIToUTF16(kAliceUsername);
     password1_ = ASCIIToUTF16(kAlicePassword);
     username2_ = ASCIIToUTF16(kBobUsername);
     password2_ = ASCIIToUTF16(kBobPassword);
@@ skipping 34 matching lines @@
     username_element_.setAutofilled(false);
     password_element_.setValue("");
     password_element_.setAutofilled(false);
   }
 
   void SimulateUsernameChange(const std::string& username,
                               bool move_caret_to_end) {
     username_element_.setValue(WebString::fromUTF8(username));
     if (move_caret_to_end)
       username_element_.setSelectionRange(username.length(), username.length());
-    view_->textFieldDidChange(username_element_);
+    autofill_helper_->textFieldDidChange(username_element_);
     // Processing is delayed because of a WebKit bug, see
     // PasswordAutocompleteManager::TextDidChangeInTextField() for details.
     MessageLoop::current()->RunAllPending();
   }
 
   void SimulateKeyDownEvent(const WebInputElement& element,
                             app::KeyboardCode key_code) {
     WebKit::WebKeyboardEvent key_event;
     key_event.windowsKeyCode = key_code;
-    view_->textFieldDidReceiveKeyDown(element, key_event);
+    autofill_helper_->textFieldDidReceiveKeyDown(element, key_event);
   }
 
   void CheckTextFieldsState(const std::string& username,
                             bool username_autofilled,
                             const std::string& password,
                             bool password_autofilled) {
     EXPECT_EQ(username,
               static_cast<std::string>(username_element_.value().utf8()));
     EXPECT_EQ(username_autofilled, username_element_.isAutofilled());
     EXPECT_EQ(password,
@@ skipping 95 matching lines @@
   SimulateUsernameChange("a", true);
   CheckTextFieldsState("a", false, "", false);
   SimulateUsernameChange("al", true);
   CheckTextFieldsState("al", false, "", false);
   SimulateUsernameChange(kAliceUsername, true);
   CheckTextFieldsState(kAliceUsername, false, "", false);
 
   // Autocomplete should happen only when the username textfield is blurred with
   // a full match.
   username_element_.setValue("a");
-  view_->textFieldDidEndEditing(username_element_);
+  autofill_helper_->textFieldDidEndEditing(username_element_);
   CheckTextFieldsState("a", false, "", false);
   username_element_.setValue("al");
-  view_->textFieldDidEndEditing(username_element_);
+  autofill_helper_->textFieldDidEndEditing(username_element_);
   CheckTextFieldsState("al", false, "", false);
   username_element_.setValue("alices");
-  view_->textFieldDidEndEditing(username_element_);
+  autofill_helper_->textFieldDidEndEditing(username_element_);
   CheckTextFieldsState("alices", false, "", false);
   username_element_.setValue(ASCIIToUTF16(kAliceUsername));
-  view_->textFieldDidEndEditing(username_element_);
+  autofill_helper_->textFieldDidEndEditing(username_element_);
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
 }
 
 // Tests that inline autocompletion works properly.
 TEST_F(PasswordAutocompleteManagerTest, InlineAutocomplete) {
   // Simulate the browser sending back the login info.
   SimulateOnFillPasswordForm(fill_data_);
 
   // Clear the textfields to start fresh.
   ClearUsernameAndPasswordFields();
@@ skipping 53 matching lines @@
   // Simulate the browser sending back the login info.
   SimulateOnFillPasswordForm(fill_data_);
 
   // Clear the textfields to start fresh.
   ClearUsernameAndPasswordFields();
 
   // To simulate a selection in the suggestion drop-down we just mimick what the
   // WebView does: it sets the element value then calls
   // didAcceptAutocompleteSuggestion on the renderer.
   username_element_.setValue(ASCIIToUTF16(kAliceUsername));
-  view_->didAcceptAutocompleteSuggestion(username_element_);
+  autofill_helper_->didAcceptAutocompleteSuggestion(username_element_);
 
   // Autocomplete should have kicked in.
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
 }