Introduce RenderView::Observer interface so that RenderView doesn't have to k...

chrome/renderer/page_click_tracker_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 
 #include "chrome/common/render_messages.h"
 #include "chrome/renderer/page_click_listener.h"
 #include "chrome/renderer/page_click_tracker.h"
 #include "chrome/test/render_view_test.h"
@@ skipping 31 matching lines @@
 
   bool called_;
   WebKit::WebInputElement element_clicked_;
   bool was_focused_;
   bool is_focused_;
   bool notification_response_;
 };
 
 // Tests that PageClickTracker does notify correctly when a node is clicked.
 TEST_F(RenderViewTest, PageClickTracker) {
+  // RenderView creates PageClickTracker but it doesn't keep it around.  Rather
+  // than make it do so for the test, we create a new object.
+  PageClickTracker* page_click_tracker = new PageClickTracker(view_);
+
   TestPageClickListener test_listener1;
   TestPageClickListener test_listener2;
-  view_->page_click_tracker()->AddListener(&test_listener1);
-  view_->page_click_tracker()->AddListener(&test_listener2);
+  page_click_tracker->AddListener(&test_listener1);
+  page_click_tracker->AddListener(&test_listener2);
 
   LoadHTML("<form>"
            "  <input type='text' id='text'></input><br>"
            "  <input type='button' id='button'></input><br>"
            "</form>");
   view_->webwidget()->resize(WebKit::WebSize(500, 500));
   view_->webwidget()->setFocus(true);
   WebKit::WebDocument document = view_->webview()->mainFrame()->document();
   WebKit::WebElement text = document.getElementById("text");
   ASSERT_FALSE(text.isNull());
@@ skipping 33 matching lines @@
 
   // Make the first listener stop the event propagation, click the text field
   // and make sure only the first listener is notified.
   test_listener1.notification_response_ = true;
   EXPECT_TRUE(SimulateElementClick("text"));
   EXPECT_TRUE(test_listener1.called_);
   EXPECT_FALSE(test_listener2.called_);
   test_listener1.ClearResults();
 
   // Make sure removing a listener work.
-  view_->page_click_tracker()->RemoveListener(&test_listener1);
+  page_click_tracker->RemoveListener(&test_listener1);
   EXPECT_TRUE(SimulateElementClick("text"));
   EXPECT_FALSE(test_listener1.called_);
   EXPECT_TRUE(test_listener2.called_);
   test_listener2.ClearResults();
 
   // Make sure we don't choke when no listeners are registered.
-  view_->page_click_tracker()->RemoveListener(&test_listener2);
+  page_click_tracker->RemoveListener(&test_listener2);
   EXPECT_TRUE(SimulateElementClick("text"));
   EXPECT_FALSE(test_listener1.called_);
   EXPECT_FALSE(test_listener2.called_);
 }