Issue 6151001: [Chrome OS] Canonicalize username before checking against whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6151001: [Chrome OS] Canonicalize username before checking against whitelist (Closed)

Created:
9 years, 11 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Chrome OS] Canonicalize username before checking against whitelist Usernames are canonicalized before whitelisting, so we must canonicalize before checking the whitelist. BUG=chromium-os:9970 TEST=unit, browser, and install on device, whitelist name with . in it, and then log in as that account Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70704

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix unit test failures #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	chrome/browser/chromeos/login/signed_settings.cc	View	1	4 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_helper_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM http://codereview.chromium.org/6151001/diff/1/chrome/browser/chromeos/login/signed_settings.cc File chrome/browser/chromeos/login/signed_settings.cc (right): http://codereview.chromium.org/6151001/diff/1/chrome/browser/chromeos/login/signed_settings.cc#newcode154 chrome/browser/chromeos/login/signed_settings.cc:154: LOG(WARNING) << "HEY! " << email_; nit: remove ...

9 years, 11 months ago (2011-01-06 23:28:26 UTC) #2

Chris Masone

9 years, 11 months ago (2011-01-06 23:29:48 UTC) #3

On Thu, Jan 6, 2011 at 3:28 PM, <xiyuan@chromium.org> wrote:

> LGTM
>
>
>
>
http://codereview.chromium.org/6151001/diff/1/chrome/browser/chromeos/login/s...
> File chrome/browser/chromeos/login/signed_settings.cc (right):
>
>
>
http://codereview.chromium.org/6151001/diff/1/chrome/browser/chromeos/login/s...
> chrome/browser/chromeos/login/signed_settings.cc:154: LOG(WARNING) <<
> "HEY!  " << email_;
> nit: remove this debug LOG?
>
> Whoops!

Done

pushing


>
> http://codereview.chromium.org/6151001/
>

Expand Messages | Collapse Messages