Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 6150003: DOMUI: Implement the i18n-options attribute that allows the client to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit fix. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 6372776cc7239829304cd5de1420a1bd3f45a026..0734b6bce6ea7d68ff3309e4a58e5c6f7efa4a2a 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -293,11 +293,6 @@ cr.define('options', function() {
decorate: function() {
var self = this;
- var values = self.getAttribute('data-values');
- if (values) {
- self.initializeValues(templateData[values]);
- }
-
// Listen to pref changes.
Preferences.getInstance().addEventListener(this.pref,
function(event) {
@@ -353,24 +348,6 @@ cr.define('options', function() {
}
});
},
-
- /**
- * Sets up options in select element.
- * @param {Array} options List of option and their display text.
- * Each element in the array is an array of length 2 which contains
- * options value in the first element and display text in the second
- * element. May be undefined.
- *
- * TODO(zelidrag): move this to that i18n template classes.
- */
- initializeValues: function(options) {
- options.forEach(function (values) {
- if (this.dataType == undefined)
- this.dataType = typeof values[0];
-
- this.appendChild(new Option(values[1], values[0]));
- }, this);
- }
};
/**
« no previous file with comments | « chrome/browser/resources/options/personal_options.js ('k') | chrome/browser/resources/shared/js/i18n_template.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698