DOMUI: Implement the i18n-options attribute that allows the client to load

chrome/browser/resources/shared/js/i18n_template.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This is a simple template engine inspired by JsTemplates
  * optimized for i18n.
  *
  * It currently supports two handlers:
  *
@@ skipping 21 matching lines @@
    */
   var handlers = {
     /**
      * This handler sets the textContent of the element.
      */
     'i18n-content': function(element, attributeValue, obj) {
       element.textContent = obj[attributeValue];
     },
 
     /**
+     * This handler adds options to a select element.
+     */
+    'i18n-options': function(element, attributeValue, obj) {
+      var options = obj[attributeValue];
+      options.forEach(function(values) {
+        typeof values == 'string' ? element.appendChild(new Option(values)) :

[arv (Not doing code reviews), 2011/01/08 00:08:53]

This was not what I had in mind...

Either:

var option;
if (typeof values == 'string')
  option = new Option(values);
else
  option = new Option(values[1], values[0]);
element.appendChild(option);

or

element.appendChild(typeof values == 'string' ?
    new Option(values) : new Option(values[1], values[0]))

[James Hawkins, 2011/01/08 00:15:51]

Done.

+            element.appendChild(new Option(values[1], values[0]));
+      });
+    },
+
+    /**
      * This is used to set HTML attributes and DOM properties,. The syntax is:
      *   attributename:key;
      *   .domProperty:key;
      *   .nested.dom.property:key
      */
     'i18n-values': function(element, attributeValue, obj) {
       var parts = attributeValue.replace(/\s/g, '').split(/;/);
       for (var j = 0; j < parts.length; j++) {
         var a = parts[j].match(/^([^:]+):(.+)$/);
         if (a) {
@@ skipping 47 matching lines @@
           handlers[name](element, att, obj);
         }
       }
     }
   }
 
   return {
     process: process
   };
 })();