Issue 6146009: Do not allow accessors to intercept getting/setting properties on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6146009: Do not allow accessors to intercept getting/setting properties on... (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Do not allow accessors to intercept getting/setting properties on error objects under construction and string conversions. Committed: http://code.google.com/p/v8/source/detail?r=6291

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -4 lines)			Patch
	M	src/messages.js	View	1	2 chunks	+9 lines, -3 lines	1 comment	Download
	M	test/mjsunit/error-constructors.js	View	1	2 chunks	+26 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-12 15:46:41 UTC) #2

LGTM

http://codereview.chromium.org/6146009/diff/3001/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/6146009/diff/3001/src/messages.js#newcode955
src/messages.js:955: if (m === kAddMessageAccessorsMarker) {
Maybe add a comment that DefineOneShotAccessor ensures that there always is a
'message' property set directly on the object.

http://codereview.chromium.org/6146009/diff/3001/test/mjsunit/error-construct...
File test/mjsunit/error-constructors.js (right):

http://codereview.chromium.org/6146009/diff/3001/test/mjsunit/error-construct...
test/mjsunit/error-constructors.js:33: 
Maybe add a comment here to what this is actually testing.

Expand Messages | Collapse Messages