Issue 6145002: Fix browser crash due to bookmark bubble view loosing activation while gettin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6145002: Fix browser crash due to bookmark bubble view loosing activation while gettin... (Closed)

Created:
9 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix browser crash due to bookmark bubble view losing activation while getting shown. As mentioned in the comment: |bubble_| can be set to NULL in InfoBubbleClosing when we close the bubble asynchronously. However, that can happen during the Show call above if the window loses activation while we are getting to ready to show the bubble, so we must check to make sure we still have a valid bubble before proceeding. BUG=59524 TEST=I tried creating a UI test for this, but wasn't able to reproduce the crash with a test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71028

Patch Set 1 #

Created: 9 years, 11 months ago

		Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)
	M	chrome/browser/ui/views/bookmark_bubble_view.cc	View	2 chunks	+8 lines, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages