Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 6145002: Fix browser crash due to bookmark bubble view loosing activation while gettin... (Closed)

Created:
9 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Fix browser crash due to bookmark bubble view losing activation while getting shown. As mentioned in the comment: |bubble_| can be set to NULL in InfoBubbleClosing when we close the bubble asynchronously. However, that can happen during the Show call above if the window loses activation while we are getting to ready to show the bubble, so we must check to make sure we still have a valid bubble before proceeding. BUG=59524 TEST=I tried creating a UI test for this, but wasn't able to reproduce the crash with a test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/ui/views/bookmark_bubble_view.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
9 years, 11 months ago (2011-01-10 17:35:01 UTC) #1
sky
9 years, 11 months ago (2011-01-10 17:37:26 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698