Chromium Code Reviews

Issue 6144004: Adjust expectations. (Closed)

Created:
9 years, 11 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Adjust expectations. These 2 just needed a new baseline given their updated results. - vista-release-single-core/intl2/times/t - xp-release-single-core/dhtml/times/t BUG=none TEST=perf steps are green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71091

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -2 lines)
M tools/perf_expectations/perf_expectations.json View 2 chunks +2 lines, -2 lines 0 comments

Messages

Total messages: 2 (0 generated)
chase
9 years, 11 months ago (2011-01-11 21:57:06 UTC) #1
Nicolas Sylvain
9 years, 11 months ago (2011-01-18 20:58:47 UTC) #2
lg

On Tue, Jan 11, 2011 at 1:57 PM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Adjust expectations.
>
> These 2 just needed a new baseline given their updated
> results.
>
>  - vista-release-single-core/intl2/times/t
>  - xp-release-single-core/dhtml/times/t
>
> BUG=none
> TEST=perf steps are green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/6144004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/tools/perf_expectations
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
a8399e635055ab13ea23358aa9732a667b11b49a..b3ee4d6d73ffac13cbdd8222e3817df917a3ce76
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -54,7 +54,7 @@
>  "vista-release-dual-core/v8_benchmark/score/score": {"reva": 68694,
> "revb": 69071, "improve": 620, "regress": -713},
>  "vista-release-single-core/dhtml/times/t": {"improve": -90, "regress":
> 90},
>  "vista-release-single-core/intl1/times/t": {"improve": -510, "regress":
> 510},
> - "vista-release-single-core/intl2/times/t": {"improve": -105, "regress":
> 105},
> + "vista-release-single-core/intl2/times/t": {"reva": 70279, "revb": 71050,
> "improve": -536, "regress": 387},
>  "vista-release-single-core/morejs/times/t": {"reva": 70492, "revb": 70587,
> "improve": -115, "regress": 45},
>  "vista-release-single-core/moz/times/t": {"reva": 68700, "revb": 70551,
> "improve": -388, "regress": 375},
>  "vista-release-single-core/startup/times/t": {"improve": -9, "regress":
> 9},
> @@ -73,7 +73,7 @@
>  "xp-release-dual-core/moz/vm_peak_r/vm_pk_r": {"reva": 68696, "revb":
> 69048, "improve": -1311744, "regress": 5879194},
>  "xp-release-dual-core/startup/warm/t": {"reva": 63759, "revb": 64027,
> "improve": -4, "regress": 13},
>  "xp-release-dual-core/v8_benchmark/score/score": {"reva": 68696, "revb":
> 69071, "improve": 892, "regress": -668},
> - "xp-release-single-core/dhtml/times/t": {"improve": -21, "regress": 21},
> + "xp-release-single-core/dhtml/times/t": {"reva": 70281, "revb": 71066,
> "improve": -121, "regress": 307},
>  "xp-release-single-core/intl1/times/t": {"reva": 68814, "revb": 70586,
> "improve": -14874, "regress": 8940},
>  "xp-release-single-core/intl2/times/t": {"reva": 68834, "revb": 70586,
> "improve": -4354, "regress": 4476},
>  "xp-release-single-core/morejs/times/t": {"reva": 70451, "revb": 70587,
> "improve": -110, "regress": 46},
>
>
>

Powered by Google App Engine