Allow printing/saving a plugin through right click menu, even if it's in a fr...

chrome/renderer/print_web_view_helper.h

Index: chrome/renderer/print_web_view_helper.h
===================================================================
--- chrome/renderer/print_web_view_helper.h	(revision 70859)
+++ chrome/renderer/print_web_view_helper.h	(working copy)
@@ -41,6 +41,7 @@
  public:
   PrepareFrameAndViewForPrint(const ViewMsg_Print_Params& print_params,
                               WebKit::WebFrame* frame,
+                              WebKit::WebNode* node,

[viettrungluu, 2011/01/13 01:04:40]

Here and elsewhere (where both a frame and node are given): Can |node| always be
null? (Maybe you should add a comment on that?)

                               WebKit::WebView* web_view);
   ~PrepareFrameAndViewForPrint();
 
@@ -77,8 +78,14 @@
   explicit PrintWebViewHelper(RenderView* render_view);
   virtual ~PrintWebViewHelper();
 
-  void Print(WebKit::WebFrame* frame, bool script_initiated, bool is_preview);
+  void Print(WebKit::WebFrame* frame,
+             bool script_initiated,
+             bool is_preview);
 
+  void Print(WebKit::WebNode* node,

[viettrungluu, 2011/01/13 01:04:40]

I'm not thrilled by this overload. Can we name them differently?

+             bool script_initiated,
+             bool is_preview);
+
   // Is there a background print in progress?
   bool IsPrinting() {
     return print_web_view_ != NULL;
@@ -105,7 +112,8 @@
   // Prints all the pages listed in |params|.
   // It will implicitly revert the document to display CSS media type.
   void PrintPages(const ViewMsg_PrintPages_Params& params,
-                  WebKit::WebFrame* frame);
+                  WebKit::WebFrame* frame,
+                  WebKit::WebNode* node);
 
   // IPC::Message::Sender
   bool Send(IPC::Message* msg);
@@ -127,14 +135,22 @@
       double* margin_bottom_in_points,
       double* margin_left_in_points);
 
+  void Print(WebKit::WebFrame* frame,

[viettrungluu, 2011/01/13 01:04:40]

Maybe you should name this one differently too, to avoid confusion.
(PrintInternal?)

+             WebKit::WebNode* node,
+             bool script_initiated,
+             bool is_preview);
+
   void UpdatePrintableSizeInPrintParameters(WebKit::WebFrame* frame,
+                                            WebKit::WebNode* node,
                                             ViewMsg_Print_Params* params);
 
   // Initialize print page settings with default settings.
-  bool InitPrintSettings(WebKit::WebFrame* frame);
+  bool InitPrintSettings(WebKit::WebFrame* frame,
+                         WebKit::WebNode* node);
 
   // Get the default printer settings.
   bool GetDefaultPrintSettings(WebKit::WebFrame* frame,
+                               WebKit::WebNode* node,
                                ViewMsg_Print_Params* params);
 
   // Get final print settings from the user.
@@ -144,7 +160,8 @@
                                 bool use_browser_overlays);
 
   // Render the frame for printing.
-  void RenderPagesForPrint(WebKit::WebFrame* frame);
+  void RenderPagesForPrint(WebKit::WebFrame* frame,
+                           WebKit::WebNode* node);
 
   // Render the frame for preview.
   void RenderPagesForPreview(WebKit::WebFrame* frame);