Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 6142012: Address clang complaint about possible unrecognized function call.... (Closed)

Created:
9 years, 11 months ago by mrossetti
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Address clang complaint about possible unrecognized function call. BUG=None TEST=None TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mrossetti
9 years, 11 months ago (2011-01-11 20:32:52 UTC) #1
Nico
9 years, 11 months ago (2011-01-11 20:52:35 UTC) #2
LG

On Tue, Jan 11, 2011 at 12:32 PM,  <mrossetti@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Address clang complaint about possible unrecognized function call.
>
> BUG=None
> TEST=None
> TBR=thakis@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6142012/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
>  M     chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
>  M
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
>
>
> Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
> ===================================================================
> --- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
>  (revision 71059)
> +++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
>  (working copy)
> @@ -200,7 +200,7 @@
>  - (BOOL)canScrollDown;
>  - (CGFloat)verticalScrollArrowHeight;
>  - (NSView*)visibleView;
> -- (NSView*)scrollView;
> +- (NSScrollView*)scrollView;
>  - (NSView*)folderView;
>
>  - (BookmarkButton*)buttonForDroppingOnAtPoint:(NSPoint)point;
> Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> ===================================================================
> --- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> (revision 71070)
> +++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> (working copy)
> @@ -1662,7 +1662,7 @@
>   return visibleView_;
>  }
>
> -- (NSView*)scrollView {
> +- (NSScrollView*)scrollView {
>   return scrollView_;
>  }
>
> Index:
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
> ===================================================================
> ---
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
>        (revision 71059)
> +++
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
>        (working copy)
> @@ -470,12 +470,12 @@
>   // Also, for each scroll, make sure our hit test finds a new button
>   // (to confirm the content area changed).
>   NSView* savedHit = nil;
> -  NSView* scrollView = [bbfc scrollView];
> +  NSScrollView* scrollView = [bbfc scrollView];
>
>   // Find the next-to-last button showing at the bottom of the window and
>   // us its center for hit testing.
>   BookmarkButton* targetButton = nil;
> -  NSPoint scrollPoint = [[bbfc scrollView] documentVisibleRect].origin;
> +  NSPoint scrollPoint = [scrollView documentVisibleRect].origin;
>   for (BookmarkButton* button in [bbfc buttons]) {
>     NSRect buttonFrame = [button frame];
>     buttonFrame.origin.y -= scrollPoint.y;
> @@ -1199,7 +1199,7 @@
>   NSRect menuFrame = [folderView frame];
>   NSView* visibleView = [folderController visibleView];
>   NSRect visibleFrame = [visibleView frame];
> -  NSView* scrollView = [folderController scrollView];
> +  NSScrollView* scrollView = [folderController scrollView];
>   NSRect scrollFrame = [scrollView frame];
>
>   // Determine the margins between the scroll frame and the visible frame.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698