chrome/browser/resources/options/search_page.css - Issue 6141002: dom-ui settings: display bubbles for sub-page search results....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/search_page.css

Issue 6141002: dom-ui settings: display bubbles for sub-page search results.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 .search-hidden {	1 .search-hidden {

2 display: none;	2 display: none;

3 }	3 }

4	4

5 .search-highlighted {	5 .search-highlighted {

6 background-color: #fff29f;	6 background-color: rgba(255, 240, 120, 0.8);

7 }	7 }

	8

	9 .search-bubble {

	10 position: absolute;

	11 left: -1000px; /* minor hack: position off-screen by default */
	arv (Not doing code reviews) 2011/01/07 22:09:45 Use top: -1000px instead Use top: -1000px instead csilv 2011/01/20 21:40:30 Done. Show quoted text On 2011/01/07 22:09:45, arv wrote: > Use top: -1000px instead Done.
	12 top: 0px;
	arv (Not doing code reviews) 2011/01/07 22:09:45 s/0px/0/ s/0px/0/ csilv 2011/01/20 21:40:30 Done. Show quoted text On 2011/01/07 22:09:45, arv wrote: > s/0px/0/ Done.
	13 width: 100px;

	14 margin: 12px 0 0;

	15 padding: 4px 10px;

	16 background-color: rgba(255, 240, 120, 0.8);

	17 border-radius: 6px;

	18 box-shadow: 0 2px 2px #888;

	19 -webkit-box-shadow: 0 2px 2px #888;

	20 text-align: center;
	arv (Not doing code reviews) 2011/01/07 22:09:45 I think you should probably have pointer-events: n I think you should probably have pointer-events: none here so that the bubbles do not block the underlying label/control. csilv 2011/01/20 21:40:30 Done. Show quoted text On 2011/01/07 22:09:45, arv wrote: > I think you should probably have pointer-events: none here so that the bubbles > do not block the underlying label/control. Done.
	21 }

	22

	23 .search-bubble:after {
	arv (Not doing code reviews) 2011/01/07 22:09:45 Could you explain what this is for? Could you explain what this is for? csilv 2011/01/20 21:40:30 This is used to create the bubble "pointer" (arrow Show quoted text On 2011/01/07 22:09:45, arv wrote: > Could you explain what this is for? This is used to create the bubble "pointer" (arrow pointing up).
	24 content: "";

	25 position: absolute;

	26 top: -10px;

	27 left: 50px;

	28 border-width: 0 10px 10px;

	29 border-style: solid;

	30 border-color: rgba(255, 240, 120, 0.8) transparent;

	31 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/options/search_page.js » ('j') | chrome/browser/resources/options/search_page.js » ('J')