Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Issue 6139006: Change the flash sandbox policy to add support for:... (Closed)

Created:
9 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Change the flash sandbox policy to add support for: - webcam (as in youtube.com\my_webcam) - gtalk BUG=64356 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71129

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M chrome/common/sandbox_policy.cc View 1 3 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
the gtalk npapi plugin exposes a an array of virtual webcams which cannot be easily ...
9 years, 11 months ago (2011-01-11 02:17:12 UTC) #1
rvargas (doing something else)
drive by http://codereview.chromium.org/6139006/diff/1/chrome/common/sandbox_policy.cc File chrome/common/sandbox_policy.cc (right): http://codereview.chromium.org/6139006/diff/1/chrome/common/sandbox_policy.cc#newcode330 chrome/common/sandbox_policy.cc:330: // input path. In this case if ...
9 years, 11 months ago (2011-01-11 03:46:32 UTC) #2
rvargas (doing something else)
LGTM
9 years, 11 months ago (2011-01-11 23:35:06 UTC) #3
nsylvain
9 years, 11 months ago (2011-01-18 21:06:54 UTC) #4
I wonder if we should add a DENY rule (Do we even have that?) for the
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion key, (which
contains WinLogon).  That'd be sad if the sandbox end up being able to read that
key.

code LGTM though

Powered by Google App Engine
This is Rietveld 408576698