Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 6139002: Implement DoCallKeyed for arm lithium compiler. (Closed)

Created:
9 years, 11 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement DoCallKeyed for arm lithium compiler. Per the LChunkBuilder::DoCallKeyed the key value is placed into r2 where the KeyedCallIC expects it already so, inspired by the ia32 implementation and the DoCallNamed this code seems to be all that is required. I ran the arm tests: ./tools/test.py --simulator=arm -j4 also presubmit.py (clean) and constructed code that did trigger lithium compilation of the keyed call instruction. Before my change the code caused bailout due to unimplemented DoCallKeyed, after the change, the lithium compilation succeeded, and the code worked. Thank you! Martin Landed in r6234.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Martin Maly
9 years, 11 months ago (2011-01-09 20:19:31 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-10 07:56:08 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698