Issue 6139001: If speech input is disabled and we receive IPC calls, terminate the renderer....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6139001: If speech input is disabled and we receive IPC calls, terminate the renderer.... (Closed)

Created:
9 years, 11 months ago by jschuh

Modified:
9 years, 6 months ago

Reviewers:
Satish

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/552/src/

Visibility:
Public.

Description

If speech input is disabled and we receive IPC calls, terminate the renderer. BUG=68666 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70671

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -15 lines)			Patch
M	chrome/browser/speech/speech_input_dispatcher_host.cc	View		1 chunk	+24 lines, -12 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/speech/speech_input_manager.cc	View	1 2	2 chunks	+25 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Satish

9 years, 11 months ago (2011-01-06 21:49:41 UTC) #1

http://codereview.chromium.org/6139001/diff/1/chrome/browser/renderer_host/br...
File chrome/browser/renderer_host/browser_render_process_host.cc (right):

http://codereview.chromium.org/6139001/diff/1/chrome/browser/renderer_host/br...
chrome/browser/renderer_host/browser_render_process_host.cc:48: #include
"chrome/browser/speech/speech_input_manager.h"
this could be rolled back since there is no new code in this file

http://codereview.chromium.org/6139001/diff/1/chrome/browser/speech/speech_in...
File chrome/browser/speech/speech_input_manager.cc (right):

http://codereview.chromium.org/6139001/diff/1/chrome/browser/speech/speech_in...
chrome/browser/speech/speech_input_manager.cc:9: #include "base/lock.h"
is this required?

http://codereview.chromium.org/6139001/diff/1/chrome/browser/speech/speech_in...
chrome/browser/speech/speech_input_manager.cc:11: #include
"base/lazy_instance.h"
are these 2 lines required?

http://codereview.chromium.org/6139001/diff/1/chrome/browser/speech/speech_in...
chrome/browser/speech/speech_input_manager.cc:94: // We need to evaluate whether
IO is OK here. http://crbug.com/63335.
since are only rolling out stable channel from this branch now, you could remove
all this channel checking code and just set enabled=false for this else-if case.
That would also reduce the include files.

Expand Messages | Collapse Messages