Issue 6138005: crash-reporter: Send systemwide stability information up to Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6138005: crash-reporter: Send systemwide stability information up to Chrome (Closed)

Created:
9 years, 11 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master

Visibility:
Public.

Description

crash-reporter: Send systemwide stability information up to Chrome Change-Id: Idcb3dff3b98951b41a55b9f48968c3608b44efae BUG=9352 TEST= 1) UserCrash 2) Crash random process and verify Chrome indicates "other user" crashes occurred in its stability UMA data. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=cae3106

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add reference to bug in todo #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	crash_reporter.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 11 months ago (2011-01-10 18:51:40 UTC) #2

LGTM

http://codereview.chromium.org/6138005/diff/1/crash_reporter.cc
File crash_reporter.cc (right):

http://codereview.chromium.org/6138005/diff/1/crash_reporter.cc#newcode56
crash_reporter.cc:56: // TODO(kmixter): We can remove this histogram once we
have
File a cleanup issue?

Expand Messages | Collapse Messages