Issue 6135007: Make audio example up-to-date

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6135007: Make audio example up-to-date (Closed)

Created:
9 years, 11 months ago by nfullagar

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make audio example up-to-date BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71095

Patch Set 6 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -18 lines)			Patch
	M	ppapi/examples/audio/audio.cc	View	1 2 3 4 5	2 chunks	+31 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nfullagar

Fixed a few bugs in the example, please take another look. thx. On Mon, Jan ...

9 years, 11 months ago (2011-01-11 02:39:41 UTC) #3

brettw

LGTM http://codereview.chromium.org/6135007/diff/3/ppapi/examples/audio/audio.cc File ppapi/examples/audio/audio.cc (right): http://codereview.chromium.org/6135007/diff/3/ppapi/examples/audio/audio.cc#newcode56 ppapi/examples/audio/audio.cc:56: // add delta, keep within -kTwoPi..kTwoPi to preserve ...

9 years, 11 months ago (2011-01-11 04:13:41 UTC) #4

thx, comments addressed, checked in r71095

Expand Messages | Collapse Messages

Issue 6135007: Make audio example up-to-date (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages