Fixing omnibox continues search (pyauto) problem on non-mac machine

Fixing omnibox continues search (pyauto)  problem on non-mac machine

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70794

[sunandt, 2011-01-07 20:35:36]

On 2011/01/07 20:32:42, rohitbm wrote:

LGTM

[Nirnimesh, 2011-01-07 21:03:03]

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py
File functional/omnibox.py (right):

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode313
functional/omnibox.py:313: if not self.IsMac():
why not do this even on Mac?

[rohitbm, 2011-01-07 21:34:16]

I have uploaded the code changes.

Thanks,
Rohit
On 2011/01/07 21:03:03, Nirnimesh wrote:
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py
> File functional/omnibox.py (right):
> 
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode313
> functional/omnibox.py:313: if not self.IsMac():
> why not do this even on Mac?
Not sure why, but omnibox on mac chrome handles results change without setting
it to blank or any other string.  But having this enabled on mac doesn't harm. 
Done.

[sunandt, 2011-01-07 21:41:51]

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py
File functional/omnibox.py (right):

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode286
functional/omnibox.py:286: if not self.IsMac():
To be consistent, I think you should remove the check here as well.

[Nirnimesh, 2011-01-07 22:05:51]

LGTM

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py
File functional/omnibox.py (right):

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode283
functional/omnibox.py:283: # On Windows, omnibox doesn't change results if
searching the same text
and fix this comment

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode286
functional/omnibox.py:286: if not self.IsMac():
On 2011/01/07 21:41:51, sunandt wrote:
> To be consistent, I think you should remove the check here as well.

+1

http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode314
functional/omnibox.py:314: self.SetOmniboxText('')
add a comment here

[rohitbm, 2011-01-07 22:22:18]

On 2011/01/07 22:05:51, Nirnimesh wrote:
> LGTM
> 
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py
> File functional/omnibox.py (right):
> 
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode283
> functional/omnibox.py:283: # On Windows, omnibox doesn't change results if
> searching the same text
> and fix this comment
Done.
> 
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode286
> functional/omnibox.py:286: if not self.IsMac():
> On 2011/01/07 21:41:51, sunandt wrote:
> > To be consistent, I think you should remove the check here as well.
> 
> +1
Done.
> 
> http://codereview.chromium.org/6135005/diff/1/functional/omnibox.py#newcode314
> functional/omnibox.py:314: self.SetOmniboxText('')
> add a comment here
Done.