Add simple update test to pfq.

bin/cbuildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """CBuildbot is wrapper around the build process used by the pre-flight queue"""
 
 import errno
 import heapq
@@ skipping 397 matching lines @@
     shutil.rmtree(results_dir_in_chroot)
 
   cwd = os.path.join(buildroot, 'src', 'scripts')
   RunCommand(['bin/cros_run_vm_test',
               '--no_graphics',
               '--results_dir_root=%s' % results_dir,
               'suite_Smoke',
               ], cwd=cwd, error_ok=False)
 
 
+def _RunAUTest(buildroot):
+  """Runs a basic update test from the au test harness."""
+  cwd = os.path.join(buildroot, 'src', 'scripts')
+  image_path = os.path.join(buildroot, 'src', 'build', 'images', board,
+                            'latest', 'chromiumos_test_image.bin')
+  RunCommand(['bin/cros_run_au_test_harness',
+              '--no_graphics',
+              '--no_delta',
+              '--test_prefix=SimpleTest',
+              '--verbose',
+              '--base_image=%s' % image_path,

[petkov, 2011/01/07 01:10:42]

SimpleTest hardcodes target_image as the source image. Is base_image really
useful then? If not, can you replace with an empty string or /dev/null or
something? Or add a comment.

[sosa, 2011/01/07 22:10:02]

Changed test to just use base_image to target_image. Makes the test a little
more generic as well

On 2011/01/07 01:10:42, petkov wrote:

+              '--target_image=%s' % image_path,

[petkov, 2011/01/07 01:10:42]

does anybody check that the device really updated into the new image? if it's
done by the version, the test may report success on failures. it could be done
by checking rootdev before/after...

[sosa, 2011/01/07 22:10:02]

image_to_live does the following.

1)  Verifies the version string
2)  Verifies that we have changed the root partition.

I think these two would catch a correct update


On 2011/01/07 01:10:42, petkov wrote:

+              ], cwd=cwd, error_ok=False)
+
+
 def _UprevPackages(buildroot, tracking_branch, revisionfile, board, overlays):
   """Uprevs a package based on given revisionfile.
 
   If revisionfile is set to None or does not resolve to an actual file, this
   function will uprev all packages.
 
   Keyword arguments:
   revisionfile -- string specifying a file that contains a list of revisions to
       uprev.
   """
@@ skipping 260 matching lines @@
                      buildconfig['board'], rev_overlays)
 
     _EnableLocalAccount(buildroot)
     _Build(buildroot, emptytree)
 
     if buildconfig['unittests'] and options.tests:
       _RunUnitTests(buildroot)
 
     _BuildImage(buildroot)
 
-    if buildconfig['smoke_bvt'] and options.tests:
+    if buildconfig['tests'] and options.tests:
       _BuildVMImageForTesting(buildroot)
       test_results_dir = '/tmp/run_remote_tests.%s' % options.buildnumber
       try:
         _RunSmokeSuite(buildroot, test_results_dir)
+        _RunAUTest(buildroot)
       finally:
         if not options.debug:
           archive_full_path = os.path.join(options.gsutil_archive,
-                                         str(options.buildnumber))
+                                           str(options.buildnumber))
           _ArchiveTestResults(buildroot, buildconfig['board'],
                               test_results_dir=test_results_dir,
                               gsutil=options.gsutil,
                               archive_dir=archive_full_path,
                               acl=options.acl)
 
     if buildconfig['uprev']:
       # Don't push changes for developers.
       if buildconfig['master']:
         # Master bot needs to check if the other slaves completed.
@@ skipping 14 matching lines @@
   except:
     # Send failure to master bot.
     if not buildconfig['master'] and buildconfig['important']:
       cbuildbot_comm.PublishStatus(cbuildbot_comm.STATUS_BUILD_FAILED)
 
     raise
 
 
 if __name__ == '__main__':
     main()